some refactoring and fixes for edge cases

[benneti]

Problem

• [x] webinterface install fails
• [x] code improvements
• [x] add option to make bot admin of synapse instance
• [ ] fix making the bot synapse admin

PR Status

• [ ] Code finished.
• [ ] Tested with Package_check.
• [ ] Fix or enhancement tested.
• [ ] Upgrade from last version tested.
• [ ] Can be reviewed and tested.

Package_check results

---

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

[benneti]

!testme

[yunohost-bot]

Meow :cat2:

[Gredin67]

if fix making the bot synapse admin is this a problem with #10 I would comment out the line and merge in master. Setting the bot admin can be done manually and only deserves to be able to gather bridge rooms in a community. Which in the moment is deprecated I guess with spaces.

[Gredin67]

not sure what you are doing with the config file at update but I get https://paste.yunohost.org/raw/olecozasiq I think I found a typo that I corrected in the patch branch

[Gredin67]

anyway the config file handling will change drastically with next yunohost upgrade, so no need to try to solve this now. Better work on using the new config panel instead.

[benneti]

yeah the fix for making the bot admin is not that important it just leads to a warning which is fine, and good to know that it is close to obsolete. If I look at the logs I am slightly confused, because the error is that the logs do not exist, but for the upgrade at least it should already exist. It would probably not hurt to have mkdir, and touch in there.

Lastly I don't think I will invest much time in converting to the new config interface as I just retired my yunohost board as it was getting to slow (and the new server runs nixos)!

Anyway thanks for the input!

[benneti]

i'll wait for a bit before merging, I am still thinking about dropping the make admin option completely (and disabling communities) as it seems to not work anyway.

[benneti]

This will probably the last update of the build from my side, as I switched my homeserver over to nixos and cannot test it in the real world.

[benneti]

!testme

[yunohost-bot]

:sunflower: