YunoHost-Apps / minetest_ynh

Minetest package for YunoHost
https://www.minetest.net/
GNU Affero General Public License v3.0
7 stars 8 forks source link

Testing #58

Closed ericgaspar closed 6 months ago

ericgaspar commented 7 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 7 months ago

!testme

yunohost-bot commented 7 months ago

:rocket: Test Badge

yunohost-bot commented 7 months ago

:worm: Test Badge

supermamie commented 7 months ago

Upgrade done on my server, successfully. (And no, my server is not on bookworm yet)

supermamie commented 7 months ago

I just tested the upgrade with all those changes, and it failed : https://paste.yunohost.org/raw/otaqufequp

Here are the last lines of the log : 

2024-04-03 11:05:39,300: DEBUG - + apt-get --assume-yes --quiet -o=Acquire::Retries=3 -o=Dpkg::Use-Pty=0 --no-remove --option Dpkg::Options::=--force-confdef --option Dpkg::Options::=--force-confold install libcurl4-gnutls-dev --dry-run
2024-04-03 11:05:40,486: WARNING - The following packages have unmet dependencies:
2024-04-03 11:05:40,487: WARNING -  libcurl4-gnutls-dev : Conflicts: libcurl4-openssl-dev but 7.74.0-1.3+deb11u11 is to be installed
2024-04-03 11:05:40,487: WARNING -  libcurl4-openssl-dev : Conflicts: libcurl4-gnutls-dev but 7.74.0-1.3+deb11u11 is to be installed
2024-04-03 11:05:40,488: DEBUG - + ynh_die '--message=Unable to install dependencies'
2024-04-03 11:05:40,538: DEBUG - + ynh_exit_properly
2024-04-03 11:05:40,538: DEBUG - + [[ provision_or_update_apt =~ ^install$|^upgrade$|^restore$ ]]
2024-04-03 11:05:40,541: WARNING - Unable to install dependencies
2024-04-03 11:05:42,137: ERROR - provision_or_update failed for apt : An error occured inside the script snippet
alexAubin commented 7 months ago

@supermamie : hmmmyes that's an annoying conflict between libcurl4-openssl-dev and libcurl4-gnutls-dev ... Not sure how to deal with that, my guess is that for some reason you already have libcurl4-openssl-dev or libcurl4-gnutls-dev installed ...

Can you check this:

apt install aptitude
aptitude why libcurl4-openssl-dev
aptitude why libcurl4-gnutls-dev
alexAubin commented 7 months ago

!testme

yunohost-bot commented 7 months ago

Meow :cat2: Test Badge

yunohost-bot commented 7 months ago

Living in the future, are we? Test Badge

supermamie commented 7 months ago
aptitude why libcurl4-openssl-dev
aptitude why libcurl4-gnutls-dev

Here are the results :

root@myserver:~# aptitude why libcurl4-openssl-dev
i   minetest-ynh-deps    Dépend  libcurl4-dev
i A libcurl4-openssl-dev Fournit libcurl4-dev
root@myserver:~# aptitude why libcurl4-gnutls-dev
i   python3-reportbug    Dépend  python3-debianbts (>= 2.10)
i A python3-debianbts    Dépend  python3-pysimplesoap       
i A python3-pysimplesoap Dépend  python3-pycurl             
i A python3-pycurl       Suggère libcurl4-gnutls-dev   
orhtej2 commented 7 months ago

Checking again with generic libcurl4-dev....: https://github.com/YunoHost-Apps/minetest_ynh/pull/61

orhtej2 commented 7 months ago

Seems to be working, can you @supermamie try after creating a proper backup?

sudo yunohost app upgrade minetest -u https://github.com/orhtej2/minetest_ynh/tree/patch-1
supermamie commented 7 months ago

@orhtej2 your branch is working on my server :+1:

tituspijean commented 7 months ago

!testme !bookwormtestme

yunohost-bot commented 7 months ago

Alrighty! Test Badge

yunohost-bot commented 7 months ago

:book: Test Badge

tituspijean commented 7 months ago

Here upgrade from 7502e815 is failing due to a typo in the old manifest.json which was not fixed before migrating to packaging v2. Let's remove that test when we release YunoHost 12?

alexAubin commented 6 months ago

(Yes, level 8->6 regressions like this are expected when for major debian upgrades, it's not a huge deal)