Prevent sysctl use in any lxc container

YunoHost-Apps / minidlna_ynh

MiniDLNA (ReadyMedia) package for YunoHost

GNU General Public License v3.0

2 stars 4 forks source link

Prevent sysctl use in any lxc container #26

Open autra opened 2 years ago

autra commented 2 years ago

I often use ./ynh-dev and lxc containers to experiment, test, bugfix yunohost and applications. For this reason I propose to exclude sysctl exclusion on all lxc containers, not only in package_check CI.

This will allow me to restore backups taken from my instance in test instances, for example.

Thanks!

autra commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Alrighty!

fflorent commented 1 year ago

Your patch looks good to me (FWIW, I am not the maintainer of this app).

I'd just suggest to also remove the IS_PACKAGE_CHECK definition in _common.sh.

Salamandar commented 9 months ago

Rebased on latest testing.

Salamandar commented 9 months ago

!testme

yunohost-bot commented 9 months ago

:v:

autra commented 9 months ago

I'd just suggest to also remove the IS_PACKAGE_CHECK definition in _common.sh.

I missed this comment! Indeed...

I pushed a commit that removes _common.sh, as it is now empty.

autra commented 9 months ago

actually backtracking : I just removed the package check bypassing but I kept common.sh, until I hear from a reviewer, as it is in example_ynh.