YunoHost-Apps / misskey_ynh

Misskey package for YunoHost
https://misskey-hub.net/
GNU Affero General Public License v3.0
31 stars 14 forks source link

Update to Misskey v13, NodeJS 18.13.0, remove Yarn, add pnpm #145

Open oufmilo opened 1 year ago

oufmilo commented 1 year ago

Update NodeJS 18.13.0 + Remove Yarn + Add pnpm

Problem

I can't upgrade from current version since i've changed the install script due to pnpm. And it doesn't recognize git

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

oufmilo commented 1 year ago

Test Badge

oufmilo commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

Lastorder-DC commented 1 year ago

git submodule update --init should be added to fetch fluent-emojis and missky assets

oufmilo commented 1 year ago

!testme

yunohost-bot commented 1 year ago

May the CI gods be with you! Test Badge

oufmilo commented 1 year ago

Test Badge

lapineige commented 1 year ago

git submodule update --init should be added to fetch fluent-emojis and missky assets

Is there any way to do that without relying on git to download the release ? Because if I understand correctly this won't allow us to set a fixed version (and sha256sum it properly) ?

oufmilo commented 1 year ago

I'm waiting a reviewer to see if I'm on the good way 🤞

lapineige commented 1 year ago

ping @YunoHost-Apps/apps-group then ?

oufmilo commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Meow :cat2: Test Badge

oufmilo commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower: Test Badge

yunohost-bot commented 1 year ago

:v: Test Badge

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower: Test Badge

lapineige commented 1 year ago

Maybe the title has to be edited to state that this include v13 ?

tituspijean commented 1 year ago

!testme

yunohost-bot commented 1 year ago

May the CI gods be with you! Test Badge

tituspijean commented 1 year ago

@oufmilo, cf. review above, what do you think about the proposal to switch back to zip files instead of git? The submodules could easily be updated if we switch to packaging v2.