YunoHost-Apps / monica_ynh

Monica package for YunoHost
https://www.monicahq.com/
GNU Affero General Public License v3.0
18 stars 13 forks source link

Installation fails - cypress binary not found #75

Open cartoonnerie opened 10 months ago

cartoonnerie commented 10 months ago

Describe the bug

The installation fails. According to the logs, it seems to be because cypress is no longer available at the designated url :

2024-01-07 19:17:47,512: DEBUG - Installing Cypress (version: 7.7.0)
2024-01-07 19:17:47,512: DEBUG - 
2024-01-07 19:17:47,513: DEBUG - [STARTED] Task without title.
2024-01-07 19:17:47,514: DEBUG - [FAILED] The Cypress App could not be downloaded.
2024-01-07 19:17:47,515: DEBUG - [FAILED]
2024-01-07 19:17:47,515: DEBUG - [FAILED] Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration
2024-01-07 19:17:47,516: DEBUG - [FAILED]
2024-01-07 19:17:47,517: DEBUG - [FAILED] Otherwise, please check network connectivity and try again:
2024-01-07 19:17:47,517: DEBUG - [FAILED]
2024-01-07 19:17:47,518: DEBUG - [FAILED] ----------
2024-01-07 19:17:47,518: DEBUG - [FAILED]
2024-01-07 19:17:47,519: DEBUG - [FAILED] URL: https://download.cypress.io/desktop/7.7.0?platform=linux&arch=ia32
2024-01-07 19:17:47,519: DEBUG - [FAILED] Error: Failed downloading the Cypress binary.
2024-01-07 19:17:47,520: DEBUG - [FAILED] Response code: 404
2024-01-07 19:17:47,521: DEBUG - [FAILED] Response message: Not Found
2024-01-07 19:17:47,522: DEBUG - [FAILED]
2024-01-07 19:17:47,523: DEBUG - [FAILED] ----------
2024-01-07 19:17:47,524: DEBUG - [FAILED]
2024-01-07 19:17:47,525: DEBUG - [FAILED] Platform: linux (Debian - 11)
2024-01-07 19:17:47,526: DEBUG - [FAILED] Cypress Version: 7.7.0

When I go to the filing url https://download.cypress.io/desktop/7.7.0?platform=linux&arch=ia32 through my browser, the link indeed does not work.

According to this issue https://github.com/monicahq/monica/issues/6489, it seems that the installation done by the script follows a dev config and not a user cofig. Indeed, yarn install will install also install dev dependencies since NODE_ENV is not set (according to the logs). I do not know of best practices in yunohost apps, but either NODE_ENV should be set to production or yarn install should be called with option --production=true

Context

Steps to reproduce

sudo yunohost app install monica

Expected behavior

Installation should succeed

Logs

yunohost logs