YunoHost-Apps / monica_ynh

Monica package for YunoHost
https://www.monicahq.com/
GNU Affero General Public License v3.0
18 stars 13 forks source link

Installation fails - status set to notworking in one week #8

Closed JimboJoe closed 6 years ago

JimboJoe commented 7 years ago

Hello @rndmh3ro,

Your app failed to install on our CI, hence it will be set at notworking status in one week unless installation is fixed.

You can find the complete log here https://ci-apps.yunohost.org/jenkins/job/monica%20(Community)/6/consoleFull

Don't hesitate to join our Apps packaging room on XMPP (apps@conference.yunohost.org) for help!

The YunoHost Apps Group

rndmh3ro commented 7 years ago

I completely revamped the installation, removal, backup and restore scripts, according to latest yunohost standards. Most of it looks fine, except for the incorrect_path check. It fails with Error: yunohost cli - Invalid choice for argument 'path', it must be one of /

Can you explain, what this check does and why it does fail? I don not understand this from the documentation.

JimboJoe commented 7 years ago

Hi, this test tries to install the application with a "malformed" URL: with the default check_process file, it tries to install with path path/. In your case, your manifest restricts here path entries to only /. So, as package_check tries to install with path path/, it fails with the error message Invalid choice for argument 'path', it must be one of /. Thus, as your package can only install at domain root, you should disable that test in your check_process file.

By the way, by just reading your install script, you should use ynh_install_app_dependencies helper here. It would allow to remove your (heavy!) added dependencies when removing package. You already used the right helper in the remove script here.

Anyway, good job, this issue can be closed! 😉

rndmh3ro commented 7 years ago

Thanks for your help!

JimboJoe commented 7 years ago

Latest CI results lead to a notworking application: https://ci-apps.yunohost.org/jenkins/job/monica%20(Community)/24/consoleFull Status will be changed to notworking in one week unless installation is fixed. Good luck 😉

maniackcrudelis commented 6 years ago

Hi,

Your app doesn't work on our CI and is currently level 0. https://ci-apps.yunohost.org/jenkins/job/monica%20(Community)/56/consoleFull

Your app will be moved at 'notworking' status by the end of this week, on May, 27 if nothing is done before to make it work.

anmol26s commented 6 years ago

It should work now.

maniackcrudelis commented 6 years ago

Still broken.

Your requirements could not be resolved to an installable set of packages.                                    
Unable to update monica core dependencies
anmol26s commented 6 years ago

Where can I see the CI ? Monica is not there in https://ci-apps.yunohost.org/jenkins/.

maniackcrudelis commented 6 years ago

I ran package check on a VM with the last version of this package.