Apply example_ynh - Githubissues

YunoHost-Apps / monitorix_ynh

Monitorix package for YunoHost

GNU Affero General Public License v3.0

3 stars 10 forks source link

Apply example_ynh #31

Closed yalh76 closed 2 years ago

yalh76 commented 2 years ago

Solution

Apply last example_ynh

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed!

Josue-T commented 2 years ago

Hello, did you test the upgrade from the old version with some data and check that on the upgrade nothing was lost ?

yalh76 commented 2 years ago

Hello, did you test the upgrade from the old version with some data and check that on the upgrade nothing was lost ?

Not for now, I will test after the package_check

Josue-T commented 2 years ago

As mentionned here there are a issue about the upgrade from the old version, that I also had. So just rewriting the package wont fix this issue.

yalh76 commented 2 years ago

As mentionned here there are a issue about the upgrade from the old version, that I also had. So just rewriting the package wont fix this issue.

Removed upgrade to 3.13.1

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed!

Josue-T commented 2 years ago

As mentionned here there are a issue about the upgrade from the old version, that I also had. So just rewriting the package wont fix this issue.

Removed upgrade to 3.13.1

Well, I didn't wanted that you remove the upgrade. I just would like that you fix correctly this upgrade.

And about this refactoring did you test manually the upgrade from the previous package and check that everything is ok and that there are no data loss and no regression. Because after all of these refactoring like that I many time saw, some month after, some regression and after is me who need to fix the issue...

Josue-T commented 2 years ago

Please don't merge the pull request if I didn't approved. If you wan't to merge like this, be the maintainer of this package and assume all issues linked to this !!!!

yalh76 commented 2 years ago

sorry, I won't