search

YunoHost-Apps / mopidy_ynh

Mopidy package for YunoHost
http://www.mopidy.com
Apache License 2.0
4 stars 7 forks source link

new YunoHost App for Mopidy #13

Closed siwinter closed 3 years ago

siwinter commented 3 years ago

In the forum, Aleks asked me to create this pull request. It is a completely new development of the YunoHost app. It works for me on a Raspberry system. Since this is my first YunoHost app, I think there is still a lot to be improved. I was unable to test the upgrade script. I stuck to the template, without always understanding everything. The check_process file is also likely incorrect. I haven't found any instructions for this either.

Please tell me how to proceed

tituspijean commented 3 years ago

@YunoHost-Apps/apps-group, let's review?

tituspijean commented 3 years ago

First, a simple CI check: !testme

yunohost-bot commented 3 years ago

:v: Test Badge

ericgaspar commented 3 years ago

@siwinter Thanks for bringing back to life Mopidy! I have made a PR #14 that fixes some of the linter warnings. The upgrade is still failing tests... Do you have write access to this repo ?

yalh76 commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket: Test Badge

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket: Test Badge

tituspijean commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:stuck_out_tongue_winking_eye: Test Badge

ericgaspar commented 3 years ago

I propose to merge this to testing so that the user can test it. Is it ok for you @siwinter ?

siwinter commented 3 years ago

I propose to merge this to testing so that the user can test it. Is it ok for you @siwinter ?

Many Thanks! My main problem is that I struggle more with github and the Yunhost development process than with the development of the app. I don't know, for example Which fork / branch should I work on and to which branch should I make my pull requests and what happens afterwards?

How is an automatic test triggered? What tests are then carried out? I thought that the file "check_process" would control all the tests. But I saw differences between the order in the badge and the one in my file.? The last test run (https://ci-apps-dev.yunohost.org/ci/job/1007)ended with a timeout. I don't know whether this is due to my scripts or the test program?

How does the review process work for my changes? Is there a deadline? Who decides whether changes are accepted?

I don't want to bore you with my stupid questions but answers would help me a lot.