search

YunoHost-Apps / mumbleserver_ynh

Mumble server package for YunoHost
https://mumble.info
GNU Affero General Public License v3.0
10 stars 5 forks source link

Missing restart or reload after certificate renewal #23

Closed julienmalik closed 4 years ago

julienmalik commented 5 years ago

When a LE certificate renewal occurred, the mumblerserver service should be restarted/reloaded.

I don't know if the core provides the necessary hook to do that

Jibec commented 5 years ago

Indeed it doesn't exist: https://yunohost.org/#/packaging_apps_hooks_fr

I'll try to ping aleks -- Jean-Baptiste Holcroft

alexAubin commented 5 years ago

Uh yeah we should implement some hooks like it's already available for user creation and similar stuff :s

alexAubin commented 5 years ago

c.f. https://github.com/YunoHost/yunohost/pull/586 (I yolocommited so this needs some testing /o)

julienmalik commented 5 years ago

It seems mumble needs a full restart to read the new certificates. A reload is not sufficient

Jibec commented 5 years ago

should be fixed by https://github.com/YunoHost-Apps/mumbleserver_ynh/pull/27 It requires YunoHost 3.4, actually in testing. I didn't test it. I'll really test once 3.4 is released officially.

@alexAubin I used a hack to find the app id, I hope it's the correct way to do it ;)

alexAubin commented 5 years ago

(a hack to find the app id ? not sure what you mean o.O)

Jibec commented 5 years ago

I used the hook file name to guess what's the value of $app

Jibec commented 4 years ago

I don't know why I never closed this issue, the fix was done long ago: https://github.com/YunoHost-Apps/mumbleserver_ynh/commit/60ef2515b18c053f6b02af8bd5545e0c2700d8ae

please reopen if required