YunoHost-Apps / mumbleserver_ynh

Mumble server package for YunoHost
https://mumble.info
GNU Affero General Public License v3.0
10 stars 5 forks source link

upgrading restores default password #44

Closed Jaxom99 closed 2 years ago

Jaxom99 commented 3 years ago

First of all, thanks for maintaining this app, and bringing it to top-level ynh :smile:

Describe the bug

Server password is reinstated when upgrading the app. The UX suffers from this, as mumbleweb users cannot use the app passwordless.

I received the upgrade mail stating "If you changed it manually and upgrade mumble, you'll find a backup in /var/www/mumbleserver." but I found no such file :/

Context

Steps to reproduce

  1. Install mumbleserver
  2. disable password by editing the mumble-server.ini file
  3. Upgrade via ynh (CLI in my case)
  4. Try to access the mumble server passwordless : it fails.

Expected behavior

The modified config file should be there, ready to be restored.

As i dig up the upgrade log, I found the backuped file in "/home/yunohost.conf/backup//var/www/mumbleserver/mumble-server.ini.backup.20210825.174614" which is rather non trivial :neutral_face:

(Turns out there was a formatting change : from "#" to ";" for commenting lines out)

Logs

https://paste.yunohost.org/raw/yehoseyola

Hopefully you'll work something out ! As for me, I restored proper UX by commenting the "serverpassword" line again.