YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access
GNU General Public License v3.0
47 stars 39 forks source link

Version 2 #101 #115

Closed ericgaspar closed 1 year ago

ericgaspar commented 1 year ago

Allow to configure extra nginx conf in $app.d/ directory #101

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:v: Test Badge

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower: Test Badge

ericgaspar commented 1 year ago

Not sure if we can remove this : https://github.com/YunoHost-Apps/my_webapp_ynh/blob/109bc1aed8c2827340a1fdc016bf72d3d4bfa5ce/scripts/remove#L25-L33

and also if we can remove the unused action folder https://github.com/YunoHost-Apps/my_webapp_ynh/tree/version-2-%23101/scripts/actions

alexAubin commented 1 year ago

Also yes : we can definitely remove the old actions folder which ain't used anyway ..

Regarding the "if mysql" block in the remove script, to me it sounds like we should keep it

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:rocket: Test Badge

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:stuck_out_tongue_winking_eye: Test Badge