YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access
GNU General Public License v3.0
48 stars 39 forks source link

Levl 5 forced #15

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago
>>>> INSTALL SCRIPT <<<<
✘ At line 36 'ynh_die' or 'exit' command is executed with system modification before.
 This system modification is an issue if a verification exit the script.
 You should move this verification before any system modification.
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No system modifications before the line 36. set -eu replaced by ynh_abort_if_errors

>>>> REMOVE SCRIPT <<<<
✘ set -u is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No set -u, but using of ynh_secure_remove

>>>> UPGRADE SCRIPT <<<<
✘ At line 31 'ynh_die' or 'exit' command is executed with system modification before.
 This system modification is an issue if a verification exit the script.
 You should move this verification before any system modification.
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No system modifications before the line 31. set -eu replaced by ynh_abort_if_errors

>>>> BACKUP SCRIPT <<<<
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419 

set -eu is at the line 10.

>>>> RESTORE SCRIPT <<<<
✘ At line 39 'ynh_die' or 'exit' command is executed with system modification before.
 This system modification is an issue if a verification exit the script.
 You should move this verification before any system modification.
✘ set -eu is missing at beginning of file. For details, look at https://dev.yunohost.org/issues/419

No system modifications before the line 39. set -eu is at the line 10.