Refactoring

[maniackcrudelis]

Problem

• Package out of date

Solution

• Package refactored to adjust to latest standards

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

~Medium decision~

• [ ] ~Complete test :~
• [ ] ~Upgrade previous version :~
• [X] ~Code review : JimboJoe~
• [ ] ~Code review :~
• [X] ~Approval (LGTM) : JimboJoe~
• [ ] ~Approval (LGTM) :~
• [ ] ~Approval (LGTM) :~
• [X] ~CI succeeded : JimboJoe~
• [ ] ~CI succeeded :~ ~One public package check log is enough instead of two checks.
  When the PR is mark as ready to merge, you have to wait for 7 days before really merge it.~

Since this PR has been rerouted from master to testing. It passes to a minor decision.

• [X] Upgrade previous version : JimboJoe
• [x] Code review : JimboJoe
• [x] Approval (LGTM) : JimboJoe
• [x] Approval (LGTM) : frju365
• [x] CI succeeded : JimboJoe When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

[JimboJoe]

Upgrade from previous version failed; php fpm log:

2017/08/30 19:30:53 [error] 8485#0: *98213 connect() to unix:/var/run/php5-fpm-my_webapp.sock failed (111: Connection refused) while connecting to upstream, client: etc.

As webapp1 user already exists, nothing is done during upgrade. But existing webapp1 user belongs to www-data group, as opposed to newly created webapp1 users that belong to newly created webapp1 group. As php fpm configuration file points to webapp1 user / webapp1 group, my user had insufficient rights. I had to do:

groupadd webapp1
usermod -g webapp1 webapp1

[JimboJoe]

Bump on the "upgrade from last version" issue...

[JimboJoe]

Will be merged in testing in 3 days.