search

YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access
GNU General Public License v3.0
48 stars 39 forks source link

Force https #18

Closed anmol26s closed 6 years ago

anmol26s commented 6 years ago

Problem

Every time this app is installed, the nginx file needs to edited to force the https. This should be there by default in the nginx config file.

Solution

Add a redirection from "http://" to "https://" in nginx.conf.

PR Status

Work finished. Could be reviewed and tested.

Validation

Micro-decision

frju365 commented 6 years ago

@maniackcrudelis : Can we pass this PR in micro-decision ?

JimboJoe commented 6 years ago

I agree with the micro-decision, but I'd rather have correct spacings... 😉

frju365 commented 6 years ago

yes, true. Perhaps add correct indentation, @anmol26s.

anmol26s commented 6 years ago

@JimboJoe @frju365 done Thanks

frju365 commented 6 years ago

ok. Let's merge it.

anmol26s commented 6 years ago

The testing is ok.

anmol26s commented 6 years ago

Can we merge in the master? This has been waiting for long time now.