Apply example_ynh - Githubissues

YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access

GNU General Public License v3.0

48 stars 39 forks source link

Apply example_ynh #31

Closed yalh76 closed 5 years ago

yalh76 commented 5 years ago

Problem

to solve CI error and more

Solution

And how you fix that

PR Status

[ ] Code finished.
[ ] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[ ] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Maniack C
[x] Approval (LGTM) : Maniack C
[x] Approval (LGTM) : JimboJoe
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 5 years ago

Code review OK, however this PR does not fix the CI.

yalh76 commented 5 years ago

I pushed another pull request before this one just adding the integration level: https://github.com/YunoHost-Apps/my_webapp_ynh/pull/30 This push request was failed: Because of: https://travis-ci.org/YunoHost-Apps/my_webapp_ynh/builds/481615933?utm_source=github_status&utm_medium=notification

I made all modification to let the automatic check goes fine

frju365 commented 5 years ago

I change base branch

yalh76 commented 5 years ago

I'm a bit newbie on github and Yunohost, so I tried to fix the issue for continuous integration and make the package more compliant. So do what you think the better.

maniackcrudelis commented 5 years ago

Bump

No big deal, #34 is following.

JimboJoe commented 5 years ago

The CI failed, though...

maniackcrudelis commented 5 years ago

Let see the whole picture with #34 merged as well.

Will be merged in 3 days.