Package upgrade - Githubissues

YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access

GNU General Public License v3.0

48 stars 39 forks source link

Package upgrade #34

Closed maniackcrudelis closed 5 years ago

maniackcrudelis commented 5 years ago

Problem

Global upgrade of the package.

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Kay0u
[x] Approval (LGTM) : JimboJoe
[x] Approval (LGTM) : Kay0u
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 5 years ago

Just when I was pushing, I saw https://github.com/YunoHost-Apps/my_webapp_ynh/pull/31, which I had forgotten...

So, considering the work done by @yalh76, I think we should merge his work before, then I will merge conflicts and apply the corrections from my PR. Anyway, I'm still waiting for https://github.com/YunoHost/example_ynh/pull/68 before finalizing this PR.

maniackcrudelis commented 5 years ago

~Anyone for a code review ?~ Forget it, #31 should be merged first, there will probably be conflicts after that.

maniackcrudelis commented 5 years ago

Conflicts have been resolved

Now ready for a final review.

maniackcrudelis commented 5 years ago

Will be merged in 3 days.