Global upgrade - Githubissues

maniackcrudelis commented 4 years ago

Problem

The app is no longer maintained

Solution

Take over the maintainance
Add a changelog
use scalable phpfpm
Optionnal sftp
Actions and config-panel
Merge with my own webapp

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

kay0u commented 4 years ago

We should probably wait for https://github.com/YunoHost-Apps/my_webapp_ynh/pull/46, what do you think?

maniackcrudelis commented 4 years ago

Agree

alexAubin commented 4 years ago

Alright I got tired of people reporting issues with this app so I fixed the regenconf hook

There's a CI test pending here https://ci-apps-dev.yunohost.org/jenkins/view/aleks/job/my_webapp_ynh%20(aleks)/

I intend to yolomerge this PR if it passes tests

alexAubin commented 4 years ago

Agreed to merge during today's meeting ... not sure why CI HQ fails but tests are passing on the dev CI ... (though at some point there was the same error). Will see

YunoHost-Apps / my_webapp_ynh

Global upgrade #43

Problem

Solution

PR Status

Validation