Fixes for actions and config-panel - Githubissues

YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access

GNU General Public License v3.0

48 stars 39 forks source link

Fixes for actions and config-panel #46

Closed maniackcrudelis closed 1 year ago

maniackcrudelis commented 4 years ago

Problem

Following the new tests available in package_check (https://github.com/YunoHost/package_check/commit/a5768bd046f64178b523ab8733f391f6e898cc24), the tests have spotted a lot of errors...

Solution

Fix all those errors to pass all tests.
Fix https://github.com/YunoHost-Apps/my_webapp_ynh/issues/45

PR Status

[x] Code finished.
[x] Tested with Package_check. !!!
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Kay0u
[x] Approval (LGTM) : Kay0u
[ ] Approval (LGTM) :
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 4 years ago

That's wonderful !!! I love it already !

tituspijean commented 2 years ago

Aaaaand now we should convert it to config panels v2. 🙃

alexAubin commented 1 year ago

Superseded by https://github.com/YunoHost-Apps/my_webapp_ynh/pull/94