The overwrite_nginx/phpfpm settings are madness, in particular because the one for nginx was set to false by default, which led to the app exploding as demonstrated in this issue. The whole question of handling the regen conf for apps is quite big, and the solution is not that all apps should individually implement a setting for it. If there's something to do, a global strategy should be defined and handled by the core.
Solution
Merge auto-update of github templates
Drop the overwrite_nginx/phpfpm settings
PR Status
[X] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
Problem
overwrite_nginx/phpfpm
settings are madness, in particular because the one for nginx was set to false by default, which led to the app exploding as demonstrated in this issue. The whole question of handling the regen conf for apps is quite big, and the solution is not that all apps should individually implement a setting for it. If there's something to do, a global strategy should be defined and handled by the core.Solution
overwrite_nginx/phpfpm
settingsPR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)