search

YunoHost-Apps / my_webapp_ynh

Custom Web app with SFTP access
GNU General Public License v3.0
48 stars 39 forks source link

fix #75 #76

Closed Sysdraw closed 2 years ago

Sysdraw commented 2 years ago

Problem

I have a website static in ReactJS, but when I try to go in the path https://foo.fr/test I have a redirection 404 of Nginx.

I think the configuration isn't good for modern framework as ReactJS, Angular, VueJS and more...

Solution

I did a small modifications, I have fixed the path configuration for Nginx can find the good file.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 2 years ago

Seems too specific to reactjs ... After some tests, it seems that for ReactJs, https://foo.fr/test is not a true url but a way to send arguments.

Sysdraw commented 2 years ago

Thanks, I will create a new application.

NathanRHD commented 2 years ago

I actually think it's fairly standard practice outside of react or angular frameworks for paths like /post/example-post to go to example-post.html

This is a part of the modern web, I think.

If you look at the url for this pull request, for example, it is https://github.com/YunoHost-Apps/my_webapp_ynh/pull/76 without a file extension!