search

YunoHost-Apps / mygpo_ynh

mygpo packaged for YunoHost
https://github.com/gpodder/mygpo
GNU Affero General Public License v3.0
6 stars 4 forks source link

:heavy_plus_sign: Add missing dependencies #24

Closed obrenckle closed 1 year ago

obrenckle commented 1 year ago

Problem

The dependency list was missing some packages listed as dependencies by gpodder. This caused errors while setting up the python virtualenv.

Solution

Add the missing dependencies (libffi-dev libjpeg-dev libwebp-dev) to pkg_dependencies. fixes #21

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

orhtej2 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Alrighty! Test Badge

orhtej2 commented 1 year ago

!bookwormtestme

yunohost-bot commented 1 year ago

:books: Test Badge

orhtej2 commented 1 year ago

@Jules-Bertholet can we please have this one merged? It's one of stepping stones for Bookworm compatibility.

Jules-Bertholet commented 1 year ago

@orhtej2 I will merge this, it seems reasonable, but please note that I don't use or maintain this app anymore. I will gladly transfer merge rights if anyone wants.