YunoHost-Apps / mygpo_ynh

mygpo packaged for YunoHost
https://github.com/gpodder/mygpo
GNU Affero General Public License v3.0
6 stars 4 forks source link

:bug: Use django collectstatic #25

Closed obrenckle closed 4 months ago

obrenckle commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Tagadda commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Meow :cat2: Test Badge

obrenckle commented 1 year ago

I see what happened:

  1. collectstatic waited for input when files where present

Easy enough to correct

  1. I assumed that env_path was an helper/environment variable was in fact set in another script that isn't called during restore

Setting the variable is simple, but I could use some advice. The restore task doesn't recreate the python virtual environment, it only extract existing files from the backup, which is fine if the restore is happening in exactly the same conditions than the backup, but I'm wondering what would happen the app was restored on different hardware/OS. Wouldn't it be easier to recreate the python virtual environment during restore ?

obrenckle commented 1 year ago

I fixed the errors and tested the PR with package_check this time. There's still (ignored) errors during two "Upgrade from specific commits" tests, but these happen during the initial install (so from the old commits), so I can't do much there.

Salamandar commented 8 months ago

I rebased the branch after the packagingv2 port.