Testing

[CodeShakingSheep]

Problem

• Description of why you made this PR

Solution

• And how do you fix that problem

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[CodeShakingSheep]

!testme

[yunohost-bot]

Alrighty!

[yunohost-bot]

:book:

[CodeShakingSheep]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

:worm:

[CodeShakingSheep]

I just tested upgrading from the testing branch on my server and there is an issue with ynh_app_upstream_version. Here is the relevant log part:

153729 DEBUG Executing command '['sh', '-c', '/bin/bash -x "./upgrade"  7>&1']'
153737 DEBUG + source _common.sh
153738 DEBUG ++ nodejs_version=20
153738 DEBUG +++ ynh_app_upstream_version
153741 WARNING _common.sh: line 9: ynh_app_upstream_version: command not found
153741 DEBUG ++ n8n_version=
153742 DEBUG +++ cat /etc/timezone
153742 DEBUG ++ timezone=Etc/UTC
153742 DEBUG +++ cat /etc/yunohost/current_host
153742 DEBUG ++ main_domain=business-suite.unseen-horizons.com

Nevertheless, the app is being upgraded, but not to version 1.29.0 but to the latest available version 1.34.2. :smile: Any ideas about the warning @tituspijean @alexAubin ?

[tituspijean]

If you look at the install and upgrade scripts:

source _common.sh
source /usr/share/yunohost/helpers

While calling _common.sh before the helpers (and that's the right way to do it), the ynh_app_upstream_version helper is not available. Next commit will fix that.

[tituspijean]

!testme

[yunohost-bot]

:books: :bug:

[yunohost-bot]

Meow :cat2:

[tituspijean]

! The license id 'Apache-2.0' is not registered in https://spdx.org/licenses/.

Suuuuuuure...

[CodeShakingSheep]

Awesome! Just tested it again on my server and it works fine. :raised_hands: