Add language choice for installation

[CodeShakingSheep]

Problem

Nextcloud shows the following warning:

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add "default_phone_region" with the respective ISO 3166-1 code of the region to your config file. For more details see the documentation ↗.

Solution

Added question for language in manifest.toml. Set 3 language variables (see here: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html#default-language ) in install:

• default_language
• default_locale
• default_phone_region

In upgrade I set default_phone_region if it's not set according to default_locale (which always has a value as it has a default value).

Edit: Setting default_phone_region for existing installations should be handled in config panel, cf. #638.

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[CodeShakingSheep]

!testme

[yunohost-bot]

:sunflower:

[CodeShakingSheep]

!testme

[yunohost-bot]

Fingers crossed!

[CodeShakingSheep]

!testme

[yunohost-bot]

:v:

[CodeShakingSheep]

!testme

[yunohost-bot]

Alrighty!

[CodeShakingSheep]

Alrighty!

What is going on on the test machine? There is this error which is completely unrelated to this package. Can someone look into that?

WARNING W: GPG error: https://packages.sury.org/php bullseye InRelease: The following signatures were invalid: EXPKEYSIG B188E2B695BD4743 DEB.SURY.ORG Automatic Signing Key <deb@sury.org>

[ericgaspar]

is this language choice not best handled with config panels? cf. #638

[Tagadda]

I restarted the lastest CI job https://ci-apps-dev.yunohost.org/ci/job/13727

[CodeShakingSheep]

is this language choice not best handled with config panels? cf. #638

Thanks for the hint. I hadn't checked out that PR. Indeed it seems to be the cleaner solution to set a value in config panel rather than to use a fixed default value during upgrade. So, I removed the fix in upgrade and renamed this PR accordingly.

[CodeShakingSheep]

!testme

[yunohost-bot]

May the CI gods be with you!