fix pre upgrade message

YunoHost-Apps / nextcloud_ynh

Nextcloud package for YunoHost

https://nextcloud.com/

GNU Affero General Public License v3.0

147 stars 63 forks source link

fix pre upgrade message #671

Closed OniriCorpe closed 6 months ago

OniriCorpe commented 7 months ago

Problem

the actual pre upgrade message is showed in any case, however it is not relevant if already in version 28

Solution

move it to doc/PRE_UPGRADE.d and rename it 28.0.3~ynh1.md

PR Status

[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

alexAubin commented 7 months ago

Eeeeh yeah but the thing is that we'll want this for every major version ... I guess we can duplicate it once 29.x, 30.x, etc will be out, but people jumping multiple major version will have it displayed multiple times ... But yeah the link to the forum topic is related to 28.x so meh idk watdo

OniriCorpe commented 7 months ago

there is not one major version a week, it's fine i guess x)

alexAubin commented 7 months ago

Actually nevermind, once 29.x is out we can just edit+rename the PRE_UPGRADE file such that it's only shown when upgrading to the new major version so it's fine