Make system address book access configurable

YunoHost-Apps / nextcloud_ynh

Nextcloud package for YunoHost

https://nextcloud.com/

GNU Affero General Public License v3.0

144 stars 62 forks source link

Make system address book access configurable #680

Closed tituspijean closed 2 months ago

tituspijean commented 2 months ago

Let's fix the "security issue clusterfuck".

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

tituspijean commented 2 months ago

!testme

yunohost-bot commented 2 months ago

:sunflower:

yunohost-bot commented 2 months ago

Living in the future, are we?

tituspijean commented 2 months ago

! Argument system_addressbook_exposed : you might want to simply use a boolean-type argument. No need to specify the choices list yourself.

If the standard booleans are not "yes" or "no", I have a strong flemme to add a if.