search

YunoHost-Apps / nextcloud_ynh

Nextcloud package for YunoHost
https://nextcloud.com/
GNU Affero General Public License v3.0
144 stars 62 forks source link

Fix space splitting in phpflags on install #690

Closed lyynd closed 1 month ago

lyynd commented 1 month ago

Problem

phpflags ends up being --define;apc.enable_cli=1 because of space splitting. I did not investigate why it breaks in this exact way, something inside ynh_app_setting_set. Because of this php occ in yunohost app shell does not work.

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lyynd commented 1 month ago

@ericgaspar I am not sure if this is right place to discuss this, but we might also want to fix existing instances, since the wrong setting is set on install. This would require some kind of migration. What do you think?