Correct upgrade

[Gredin67]

Problem

• access rights /var/www/onlyoffice
• only office debian package not upgrading

Solution

• [x] apply securing file from example app
• [x] several fixes/improvements for ynh_install_app_dependencies
• [ ] Use YNH_ARCH helper

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Gredin67]

!testme

We should probably replace

apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys CB2DE8E5
ynh_install_extra_repo --repo="deb http://download.onlyoffice.com/repo/debian squeeze main" --append

#=================================================
# UPGRADE ONLYOFFICE
#=================================================
ynh_script_progression --message="Upgrading OnlyOffice..."

# ynh_remove_app_dependencies
ynh_exec_warn_less ynh_add_app_dependencies --package=$extra_dependencies

by something like https://github.com/YunoHost-Apps/mautrix_signal_ynh/blob/master/scripts/upgrade#L128 But we may then fall on the same helper issue https://github.com/YunoHost-Apps/mautrix_signal_ynh/issues/22

[yunohost-bot]

:carousel_horse:

[Gredin67]

!testme

[yunohost-bot]

:rocket:

[Gredin67]

!testme

[yunohost-bot]

:rocket:

[Gredin67]

If the version still does not upgrade properly, instead of doing

# ynh_remove_app_dependencies
ynh_package_remove $extra_dependencies
ynh_install_extra_app_dependencies --repo="https://download.onlyoffice.com/repo/debian squeeze main" --package=$extra_dependencies 

we may have to tweak as in the remove script

#=================================================
# REMOVE ONLYOFFICE
#=================================================
ynh_script_progression --message="Removing OnlyOffice..."

ynh_secure_remove --file=/var/lib/dpkg/info/onlyoffice-documentserver.prerm

# Here you will wonder what the fuck this is, and the answer is : this is a
# fucking stupid hack because onlyoffice's dev deviced to put a "supervisorctl
# update" inside their postrm, but when their postrm is ran, supervisorctl is
# already removed ... so their removal fails which breaks dpkg.
# So instead, we trick it with this stupid link to /bin/true which is removed
# right after.
ln -s /bin/true /usr/local/bin/supervisorctl
ynh_package_autopurge onlyoffice-documentserver

[Gredin67]

• testing upgrade: no way to open a document
• testing install after remove : no way to link nextcloud and onlyoffice Error when trying to connect (Error occurred in the document service: Conversion error) (version 6.4.2.6).

[Gredin67]

!testme

[yunohost-bot]

May the CI gods be with you!

[Gredin67]

!testme

[yunohost-bot]

Fingers crossed!