New Permission System - Githubissues

YunoHost-Apps / opensondage_ynh

OpenSondage for YunoHost

https://framadate.org/

GNU Affero General Public License v3.0

16 stars 14 forks source link

New Permission System #59

Closed kay0u closed 3 years ago

kay0u commented 4 years ago

Problem

Description of why you made this PR

Solution

And how you fix that

PR Status

[ ] Code finished.
[ ] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[ ] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:v:

zamentur commented 3 years ago

does this PR fix https://forum.yunohost.org/t/opensondage-admin-exposed/16614 ?

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:sunflower:

ericgaspar commented 3 years ago

does this PR fix https://forum.yunohost.org/t/opensondage-admin-exposed/16614 ?

I can't access the private topic... Oops! That page doesn’t exist or is private

ericgaspar commented 3 years ago

This PR seems to resolve the exposed admin issue...

Capture d’écran 2021-07-22 à 16 41 24

@kay0u Do you know how to resolve Install (private)? 🤔

yalh76 commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket:

alexAubin commented 3 years ago

Hmpf I guess the CI fails because it expects that accessing the app url should result in being redirected to the SSO (because it's private) ... but it doesn't because for this app, being private only means that the poll creation page is accessible only to logged-in users ... zblerg