Convert to V2

[Thovi98]

Problem

• Description of why you made this PR

Solution

• And how do you fix that problem

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Thovi98]

!testme

[yunohost-bot]

:sunflower:

[Thovi98]

!testme

[yunohost-bot]

:sunflower:

[Thovi98]

!testme

[yunohost-bot]

:sunflower:

[Thovi98]

history-v1.service keeps restarting with following error:

Node.js v18.18.2
Initializing metrics
Set UV_THREADPOOL_SIZE=16
WARNING: NODE_ENV value of 'production' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
WARNING: No configurations found in configuration directory:/var/www/overleaf/config
WARNING: To disable this warning set SUPPRESS_NO_CONFIG_WARNING in the environment.
/var/www/overleaf/live/services/history-v1/storage/lib/mongodb.js:6
const client = new MongoClient(config.mongo.uri)
                                            ^

TypeError: Cannot read properties of undefined (reading 'uri')
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/mongodb.js:6:45)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/blob_store/index.js:17:17)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/chunk_store/index.js:29:23)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)

I don’t see what I miss here?

[Thovi98]

!testme

[yunohost-bot]

May the CI gods be with you!

[cichy1173]

Thank you for your work @Thovi98

Is the currently prepared package stable enough to use? Or have you fixed the upload of photos and other files?

[Thovi98]

Is the currently prepared package stable enough to use?

No, I've an issue with the history-v1 service which keeps failing... the app installs well but doesn't work ^^ I still have to debug it more.

have you fixed the upload of photos and other files?

I must say that I've never used the app before so I don't know what you are refering to 😁 If and when I find the solution, I will try to make the package with as few bugs as possible.

[cichy1173]

@Thovi98

I must say that I've never used the app before so I don't know what you are refering to 😁. If and when I find the solution, I will try to make the package with as few bugs as possible.

A few months ago I was able to install Overleaf_ynh and actually the application worked. Unfortunately, it was not possible to upload any files to projects. This made the platform basically useless. From what I was able to read at the time, this was a typical problem for all users.

[Thovi98]

For reference, the current (or one of I don’t know) issue is that overleaf-history-v1.service fails.

LOGFILE: journalctl
-- Journal begins at Sun 2023-12-17 04:35:33 CET, ends at Sun 2023-12-17 16:32:20 CET. --
déc 17 16:31:26 systemd[1]: overleaf-history-v1.service: Consumed 2.842s CPU time.
déc 17 16:31:31 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 119.
déc 17 16:31:31 systemd[1]: Stopped overleaf history-v1.
déc 17 16:31:31 systemd[1]: overleaf-history-v1.service: Consumed 2.842s CPU time.
déc 17 16:31:31 systemd[1]: Started overleaf history-v1.
déc 17 16:31:34 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:31:34 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:31:34 systemd[1]: overleaf-history-v1.service: Consumed 2.842s CPU time.
déc 17 16:31:39 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 120.
déc 17 16:31:39 systemd[1]: Stopped overleaf history-v1.
déc 17 16:31:39 systemd[1]: overleaf-history-v1.service: Consumed 2.842s CPU time.
déc 17 16:31:39 systemd[1]: Started overleaf history-v1.
déc 17 16:31:41 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:31:41 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:31:41 systemd[1]: overleaf-history-v1.service: Consumed 2.817s CPU time.
déc 17 16:31:46 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 121.
déc 17 16:31:46 systemd[1]: Stopped overleaf history-v1.
déc 17 16:31:46 systemd[1]: overleaf-history-v1.service: Consumed 2.817s CPU time.
déc 17 16:31:46 systemd[1]: Started overleaf history-v1.
déc 17 16:31:49 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:31:49 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:31:49 systemd[1]: overleaf-history-v1.service: Consumed 2.816s CPU time.
déc 17 16:31:54 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 122.
déc 17 16:31:54 systemd[1]: Stopped overleaf history-v1.
déc 17 16:31:54 systemd[1]: overleaf-history-v1.service: Consumed 2.816s CPU time.
déc 17 16:31:54 systemd[1]: Started overleaf history-v1.
déc 17 16:31:56 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:31:56 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:31:56 systemd[1]: overleaf-history-v1.service: Consumed 2.770s CPU time.
déc 17 16:32:02 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 123.
déc 17 16:32:02 systemd[1]: Stopped overleaf history-v1.
déc 17 16:32:02 systemd[1]: overleaf-history-v1.service: Consumed 2.770s CPU time.
déc 17 16:32:02 systemd[1]: Started overleaf history-v1.
déc 17 16:32:04 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:32:04 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:32:04 systemd[1]: overleaf-history-v1.service: Consumed 2.775s CPU time.
déc 17 16:32:09 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 124.
déc 17 16:32:09 systemd[1]: Stopped overleaf history-v1.
déc 17 16:32:09 systemd[1]: overleaf-history-v1.service: Consumed 2.775s CPU time.
déc 17 16:32:09 systemd[1]: Started overleaf history-v1.
déc 17 16:32:12 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:32:12 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:32:12 systemd[1]: overleaf-history-v1.service: Consumed 2.749s CPU time.
déc 17 16:32:17 systemd[1]: overleaf-history-v1.service: Scheduled restart job, restart counter is at 125.
déc 17 16:32:17 systemd[1]: Stopped overleaf history-v1.
déc 17 16:32:17 systemd[1]: overleaf-history-v1.service: Consumed 2.749s CPU time.
déc 17 16:32:17 systemd[1]: Started overleaf history-v1.
déc 17 16:32:19 systemd[1]: overleaf-history-v1.service: Main process exited, code=exited, status=1/FAILURE
déc 17 16:32:19 systemd[1]: overleaf-history-v1.service: Failed with result 'exit-code'.
déc 17 16:32:19 systemd[1]: overleaf-history-v1.service: Consumed 2.796s CPU time.

LOGFILE: /var/log/overleaf/history-v1.log
Initializing metrics
Set UV_THREADPOOL_SIZE=16
/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:9
    return (connectionString.startsWith('mongodb://') ||
                             ^

TypeError: Cannot read properties of undefined (reading 'startsWith')
    at connectionStringHasValidScheme (/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:9:30)
    at new ConnectionString (/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:85:34)
    at parseOptions (/var/www/overleaf/live/services/history-v1/node_modules/mongodb/lib/connection_string.js:185:17)
    at new MongoClient (/var/www/overleaf/live/services/history-v1/node_modules/mongodb/lib/mongo_client.js:51:63)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/mongodb.js:6:16)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/blob_store/index.js:17:17)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)

Node.js v18.18.2
Initializing metrics
Set UV_THREADPOOL_SIZE=16
/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:9
    return (connectionString.startsWith('mongodb://') ||
                             ^

TypeError: Cannot read properties of undefined (reading 'startsWith')
    at connectionStringHasValidScheme (/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:9:30)
    at new ConnectionString (/var/www/overleaf/live/node_modules/mongodb-connection-string-url/lib/index.js:85:34)
    at parseOptions (/var/www/overleaf/live/services/history-v1/node_modules/mongodb/lib/connection_string.js:185:17)
    at new MongoClient (/var/www/overleaf/live/services/history-v1/node_modules/mongodb/lib/mongo_client.js:51:63)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/mongodb.js:6:16)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/var/www/overleaf/live/services/history-v1/storage/lib/blob_store/index.js:17:17)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)

Node.js v18.18.2

[Thovi98]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[Thovi98]

!testme

[yunohost-bot]

:v:

[Thovi98]

!testme

[yunohost-bot]

Fingers crossed!

[Thovi98]

!bookwormtestme

[yunohost-bot]

:books: :worm:

[Thovi98]

!testme

[yunohost-bot]

:v:

[Thovi98]

Yeaaah! There are still some fixes to be done (like LDAP) but it’s in a good way 🎉

[Thovi98]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[cichy1173]

Yeaaah! There are still some fixes to be done (like LDAP) but it’s in a good way 🎉

Oh my god! I am terribly waiting for the final version! Overleaf is problematic on many platforms, including Docker. If it works on yunohost then I'll be so happy!

[Thovi98]

!testme

[yunohost-bot]

:carousel_horse:

[Thovi98]

!testme

[yunohost-bot]

:sunflower:

[Thovi98]

!testme

[yunohost-bot]

May the CI gods be with you!

[Thovi98]

Okay, from my point it’s ready now!

Some observations:

• I did not try to upgrade from the latest working version (because it’s not working anymore). So I don’t garantee it will successfully upgrade (nor that your actual projects will successfully migrate).
• I removed LDAP integration because it was difficult enough to make the package work already. BUT emails should work (tested on my end).
• @cichy1173 talked about an upload issue. I found the reason of it and fixed it (nginx config issue)
• It’s working for now. I don’t garantee new versions will be easily upgradable.

[cichy1173]

Great! Waiting for master release