search

YunoHost-Apps / paheko_ynh

Paheko package for YunoHost
https://paheko.cloud
GNU Affero General Public License v3.0
3 stars 5 forks source link

Update to 1.2.7 #15

Closed rodinux closed 1 year ago

rodinux commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

rodinux commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

fflorent commented 1 year ago

LGTM

rodinux commented 1 year ago

LGTM

Hello, can you also review ?

fflorent commented 1 year ago

LGTM means Looks Good To Me, means that I am OK with the merge

rodinux commented 1 year ago

Ok, so I Merge without waiting for requirements to be met (bypass branch protections) ? or I wait a reviewer, better no ?

fflorent commented 1 year ago

Is this formal approval what makes you more comfortable?

rodinux commented 1 year ago

Is this formal approval what makes you more comfortable?

sorry, I thought it was better, but anyway it's the same...