Closed rodinux closed 9 months ago
!testing
!testme
wait because it breaks with some extensions, we have a discussion about this problem...
Wait, we are not ready to push ! this release 1.3.0 have already some bugs, it is not the stable branch. I have use the 1.3.0-RC2 but this release does not exist anymore ! now there is a 1.3.0-RC3 with another checksum... We should wait to a stable release before... the uploads seems broken tonight...
!testme
@alexAubin There's a lot of changes in this major release... Do you think is better advise to take a look on the Changelog: https://fossil.kd2.org/paheko/wiki?name=Changelog/1.3
Not sure why you are pinging me specifically, I have no expertise about this app in particular
But if you mean "we should encourage people to have a look at the changelog when upgrading to this specific version because there are major changes", then maybe yes (idk, you know better than me). To achive this you can write a specific notifcation for this upgrade, cf https://yunohost.org/fr/packaging_app_doc#pre-post-install-notes-pr :
create
doc/PRE_UPGRADE.d/{version}.md
to have a note displayed before upgrading to a version equal or higher than{version}
Not sure why you are pinging me specifically, I have no expertise about this app in particular
But if you mean "we should encourage people to have a look at the changelog when upgrading to this specific version because there are major changes", then maybe yes (idk, you know better than me). To achive this you can write a specific notifcation for this upgrade, cf https://yunohost.org/fr/packaging_app_doc#pre-post-install-notes-pr :
create
doc/PRE_UPGRADE.d/{version}.md
to have a note displayed before upgrading to a version equal or higher than{version}
Thank you ! I am quiet now after have done few tests, if an old plugin is no more compatible, it will not brake the app, just an adverstisment and deleting the pugin restore a clean environment.
It works for me, just something I don't understand. When upgrading a folder seems duplicated...
ls -ll /var/www/paheko__2/data/
total 14628
-rw-r--r-- 1 paheko__2 paheko__2 5652480 27 juil. 21:33 association.pre_upgrade-1.3.0-rc3.sqlite
-rw-rw---- 1 paheko__2 www-data 9310208 27 juil. 21:33 association.sqlite
drwxrwx--- 5 paheko__2 www-data 4096 27 juil. 21:33 cache
drwxrwx--- 4 paheko__2 www-data 4096 27 juil. 21:31 data
-rw-rw---- 1 paheko__2 www-data 189 27 juil. 21:33 index.html
drwxrwx--- 8 paheko__2 www-data 4096 27 juil. 21:33 plugins
ls -ll /var/www/paheko__2/data/data/
total 5536
-rw-rw---- 1 paheko__2 www-data 5652520 27 juil. 21:31 association.sqlite
drwxrwx--- 3 paheko__2 www-data 4096 27 juil. 21:31 cache
-rw-rw---- 1 paheko__2 www-data 189 23 mai 13:57 index.html
drwxrwx--- 2 paheko__2 www-data 4096 23 mai 13:57 plugins
!testme
!testme
It works for me, just something I don't understand. When upgrading a folder seems duplicated...
ls -ll /var/www/paheko__2/data/ total 14628 -rw-r--r-- 1 paheko__2 paheko__2 5652480 27 juil. 21:33 association.pre_upgrade-1.3.0-rc3.sqlite -rw-rw---- 1 paheko__2 www-data 9310208 27 juil. 21:33 association.sqlite drwxrwx--- 5 paheko__2 www-data 4096 27 juil. 21:33 cache drwxrwx--- 4 paheko__2 www-data 4096 27 juil. 21:31 data -rw-rw---- 1 paheko__2 www-data 189 27 juil. 21:33 index.html drwxrwx--- 8 paheko__2 www-data 4096 27 juil. 21:33 plugins ls -ll /var/www/paheko__2/data/data/ total 5536 -rw-rw---- 1 paheko__2 www-data 5652520 27 juil. 21:31 association.sqlite drwxrwx--- 3 paheko__2 www-data 4096 27 juil. 21:31 cache -rw-rw---- 1 paheko__2 www-data 189 23 mai 13:57 index.html drwxrwx--- 2 paheko__2 www-data 4096 23 mai 13:57 plugins
Ok, I discover this mistake was here from a while, I have added a clean remove of the folder data/data
and now this will erase this duplicate folder, but the release works fine.
I am still waiting the stable release for this version, for now I test the 1.3.0-rc4, there is also a 1.3.0-rc5 coming soon. When the stable 1.3.0 (not release candidate) should be ready, I will merge this PR on master branch.
!testme
(Soooo, what's holding us before merging ?)
(Soooo, what's holding us before merging ?)
I wait until this branch is for now the release candidate for next major upgrade 1.3.0, but not yet stable...
Nevertheless It would be nice to first merge this PR #27 which is the upgrade from 1.2.9 to 1.2.11 (stable branch)
!testme
!testme
... I don't get why there are a gazillion conflicts with master ... Many commits / branches were merged into master since the beginning of this branch, despite the fact that this is testing, and the recommended practice is that everything should go into testing before being merged in master ... Otherwise everything becomes a huge mess ...
!testme
Well, this time the version 1.3.0 is stable ! but there is some strange things, If I upgrade from previous commit (1.3.0~ynh11) where the version was a 1.3.0-rc14
yunohost app upgrade paheko -u https://github.com/YunoHost-Apps/paheko_ynh/tree/testing --debug
the upgrade is done,
description: Logiciel libre de gestion d'association
domain_path: paheko.yunohost.packaging/
name: Paheko version: 1.3.0~ynh12
but in fact the upgrade is not done it stays on last version
cat /var/www/paheko/VERSION
1.3.0-rc14
Here the logs of this operation https://paste.yunohost.org/raw/zijuhigiro
If I do a yunohost app upgrade paheko -u https://github.com/YunoHost-Apps/paheko_ynh/tree/testing -F
it works
cat /var/www/paheko/VERSION
1.3.0
here the logs of this operation https://paste.yunohost.org/raw/axoqokamoj
Why do I need --force
??
@alexAubin or @ericgaspar or @fflorent any idea ??
I just see difference also with the command curl
that finalize the upgrade, something related to the cookies ??
we could see on the first upgrade with only --debug
2023-10-04 19:39:52,647: DEBUG - + curl --silent --show-error --insecure --location --header 'Host: paheko.maindomain.tld' --resolve paheko.maindomain.tld:443:127.0.0.1 https://localhost/index.php --cookie-jar /tmp/ynh-paheko-cookie.txt --cookie /tmp/ynh-paheko-cookie.txt
2023-10-04 19:39:52,721: DEBUG -
2023-10-04 19:39:52,721: DEBUG - <!DOCTYPE html>
2023-10-04 19:39:52,721: DEBUG - <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="fr" lang="fr" class="" data-version="4c0017d968" data-url="https://paheko.maindomain.tld/admin/">
2023-10-04 19:39:52,722: DEBUG - <head>
2023-10-04 19:39:52,723: DEBUG - <meta charset="utf-8" />
2023-10-04 19:39:52,727: DEBUG - <meta name="v" content="4c0017d968" />
2023-10-04 19:39:52,727: DEBUG - <title>Connexion</title>
2023-10-04 19:39:52,727: DEBUG - <meta name="viewport" content="width=device-width, initial-scale=1.0" />
2023-10-04 19:39:52,728: DEBUG - <link rel="stylesheet" type="text/css" href="https://paheko.maindomain.tld/admin/static/admin.css?4c0017d968" media="all" />
2023-10-04 19:39:52,728: DEBUG - <script type="text/javascript" src="https://paheko.maindomain.tld/admin/static/scripts/global.js?4c0017d968"></script>
2023-10-04 19:39:52,728: DEBUG -
2023-10-04 19:39:52,728: DEBUG -
2023-10-04 19:39:52,728: DEBUG -
2023-10-04 19:39:52,729: DEBUG -
2023-10-04 19:39:52,729: DEBUG - <link rel="stylesheet" type="text/css" href="https://paheko.maindomain.tld/admin/static/print.css?4c0017d968" media="print" />
2023-10-04 19:39:52,729: DEBUG -
2023-10-04 19:39:52,729: DEBUG - <link rel="stylesheet" type="text/css" href="https://paheko.maindomain.tld/admin/static/handheld.css?4c0017d968" media="handheld,screen and (max-width:981px)" />
2023-10-04 19:39:52,729: DEBUG -
2023-10-04 19:39:52,730: DEBUG - <link rel="manifest" href="https://paheko.maindomain.tld/admin/manifest.php" />
2023-10-04 19:39:52,730: DEBUG -
2023-10-04 19:39:52,730: DEBUG - <link rel="icon" type="image/png" href="https://paheko.maindomain.tld/admin/static/favicon.png" />
2023-10-04 19:39:52,730: DEBUG -
2023-10-04 19:39:52,730: DEBUG -
2023-10-04 19:39:52,730: DEBUG - <style type="text/css">
2023-10-04 19:39:52,730: DEBUG - :root {
2023-10-04 19:39:52,731: DEBUG - --gMainColor: 32, 120, 122;
2023-10-04 19:39:52,731: DEBUG - --gSecondColor: 133, 185, 186;
2023-10-04 19:39:52,731: DEBUG - --gBgImage: url("/config/admin_bg.png?h=526358ac36");
2023-10-04 19:39:52,731: DEBUG - }
2023-10-04 19:39:52,731: DEBUG - </style>
2023-10-04 19:39:52,731: DEBUG - <script type="text/javascript" src="/ynh_portal.js"></script><link type="text/css" rel="stylesheet" href="/ynh_overlay.css"><script type="text/javascript" src="/ynhtheme/custom_portal.js"></script><link type="text/css" rel="stylesheet" href="/ynhtheme/custom_overlay.css"></head>
2023-10-04 19:39:52,733: DEBUG -
2023-10-04 19:39:52,733: DEBUG -
2023-10-04 19:39:52,734: DEBUG -
2023-10-04 19:39:52,734: DEBUG - <body>
2023-10-04 19:39:52,734: DEBUG -
2023-10-04 19:39:52,735: DEBUG -
2023-10-04 19:39:52,735: DEBUG -
2023-10-04 19:39:52,735: DEBUG -
2023-10-04 19:39:52,735: DEBUG - <header class="header">
2023-10-04 19:39:52,735: DEBUG - <nav class="menu">
2023-10-04 19:39:52,736: DEBUG - <figure class="logo">
2023-10-04 19:39:52,736: DEBUG -
2023-10-04 19:39:52,736: DEBUG - <a href="https://paheko.maindomain.tld/admin/"><img src="/config/logo.png?150px&h=8bb8615115" alt="" /></a>
2023-10-04 19:39:52,736: DEBUG -
2023-10-04 19:39:52,737: DEBUG - </figure>
2023-10-04 19:39:52,737: DEBUG - <ul>
2023-10-04 19:39:52,737: DEBUG -
2023-10-04 19:39:52,737: DEBUG -
2023-10-04 19:39:52,738: DEBUG - <li><h3><a href="https://blog.linux07.fr"><span data-icon="←"></span><b>Retour au site</b></a></h3></li>
2023-10-04 19:39:52,738: DEBUG -
2023-10-04 19:39:52,738: DEBUG - <li class="current"><h3><a href="https://paheko.maindomain.tld/admin/"><span data-icon="⇥"></span><b>Connexion</b></a></h3></li>
2023-10-04 19:39:52,738: DEBUG -
2023-10-04 19:39:52,739: DEBUG - </ul>
2023-10-04 19:39:52,739: DEBUG - </nav>
2023-10-04 19:39:52,739: DEBUG -
2023-10-04 19:39:52,739: DEBUG -
2023-10-04 19:39:52,740: DEBUG - <h1>Connexion</h1>
2023-10-04 19:39:52,740: DEBUG -
2023-10-04 19:39:52,740: DEBUG - </header>
2023-10-04 19:39:52,741: DEBUG -
2023-10-04 19:39:52,741: DEBUG -
2023-10-04 19:39:52,741: DEBUG - <main>
2023-10-04 19:39:52,741: DEBUG -
2023-10-04 19:39:52,742: DEBUG -
2023-10-04 19:39:52,742: DEBUG -
2023-10-04 19:39:52,742: DEBUG -
2023-10-04 19:39:52,742: DEBUG -
2023-10-04 19:39:52,743: DEBUG - <p class="block error" style="display: none;" id="old_browser">
2023-10-04 19:39:52,744: DEBUG - Le navigateur que vous utilisez n'est pas supporté. Des fonctionnalités peuvent ne pas fonctionner.<br />
2023-10-04 19:39:52,745: DEBUG - Merci d'utiliser un navigateur web moderne comme <a href="https://www.getfirefox.com/" target="_blank">Firefox</a> ou <a href="https://vivaldi.com/fr/" target="_blank">Vivaldi</a>.
2023-10-04 19:39:52,745: DEBUG - </p>
2023-10-04 19:39:52,745: DEBUG -
2023-10-04 19:39:52,745: DEBUG - <form method="post" action="/admin/login.php" data-focus="1">
2023-10-04 19:39:52,746: DEBUG -
2023-10-04 19:39:52,746: DEBUG -
2023-10-04 19:39:52,747: DEBUG - <fieldset>
2023-10-04 19:39:52,747: DEBUG - <legend>
2023-10-04 19:39:52,747: DEBUG -
2023-10-04 19:39:52,747: DEBUG - <span class="confirm"><span data-icon="🔒"></span> Connexion sécurisée</span>
2023-10-04 19:39:52,748: DEBUG -
2023-10-04 19:39:52,748: DEBUG - </legend>
2023-10-04 19:39:52,748: DEBUG - <dl>
2023-10-04 19:39:52,749: DEBUG - <dt><label for="f_id">Adresse E-Mail</label> <b title="Champ obligatoire">(obligatoire)</b></dt><dd><input type="email" required="required" id="f_id" name="id" value="" /></dd>
2023-10-04 19:39:52,749: DEBUG - <dt><label for="f_password">Mot de passe</label> <b title="Champ obligatoire">(obligatoire)</b></dt><dd><input type="password" required="required" id="f_password" name="password" autocomplete="off" value="" /></dd>
2023-10-04 19:39:52,749: DEBUG -
2023-10-04 19:39:52,750: DEBUG - <dd><input type="checkbox" id="f_permanent_1" name="permanent" value="1" /> <label for="f_permanent_1">Rester connecté⋅e</label> <em class="help">(recommandé seulement sur ordinateur personnel)</em></dd>
2023-10-04 19:39:52,751: DEBUG -
2023-10-04 19:39:52,751: DEBUG - </dl>
2023-10-04 19:39:52,752: DEBUG - </fieldset>
2023-10-04 19:39:52,752: DEBUG -
2023-10-04 19:39:52,752: DEBUG -
2023-10-04 19:39:52,752: DEBUG -
2023-10-04 19:39:52,753: DEBUG - <p class="submit">
2023-10-04 19:39:52,753: DEBUG - <input type="hidden" name="ct_0de0b1d7ce1cdb43cdd7b196c79b827beac95e7e" value="9a37d0410c58cb1b5e2ccc2b8e51fb845e2b367e225cb9217017e04e5ebfbb88/730c6/15d1120f118f0fbc" />
2023-10-04 19:39:52,753: DEBUG - <button type="submit" name="login" class="main icn-btn" data-icon="→" value="1">Se connecter</button>
2023-10-04 19:39:52,754: DEBUG -
2023-10-04 19:39:52,754: DEBUG - <a href="https://paheko.maindomain.tld/admin/password.php" data-icon="❓" class=" icn-btn"><span>Mot de passe perdu ?</span></a>
2023-10-04 19:39:52,754: DEBUG - <a href="https://paheko.maindomain.tld/admin/password.php?new" data-icon="👤" class=" icn-btn"><span>Première connexion ?</span></a>
2023-10-04 19:39:52,755: DEBUG -
2023-10-04 19:39:52,755: DEBUG - </p>
2023-10-04 19:39:52,755: DEBUG -
2023-10-04 19:39:52,755: DEBUG - <p class="help">
2023-10-04 19:39:52,756: DEBUG - Suggestion : mettez cette page dans vos favoris pour la retrouver facilement :-)<br />
2023-10-04 19:39:52,756: DEBUG - <small>(Sur ordinateur appuyez sur <tt>Ctrl</tt> + <tt>D</tt>. Aide : <a href="https://support.mozilla.org/fr/kb/marque-pages-firefox#w_marquer-une-page" target="_blank">Firefox</a>, <a href="https://support.google.com/chrome/answer/188842?hl=fr&co=GENIE.Platform%3DDesktop&oco=0" target="_blank">Chrome</a>)</small>
2023-10-04 19:39:52,756: DEBUG - </p>
2023-10-04 19:39:52,756: DEBUG -
2023-10-04 19:39:52,757: DEBUG - </form>
2023-10-04 19:39:52,757: DEBUG -
2023-10-04 19:39:52,757: DEBUG -
2023-10-04 19:39:52,757: DEBUG - <script type="text/javascript" async="async">
2023-10-04 19:39:52,758: DEBUG - if (window.navigator.userAgent.match(/MSIE|Trident\/|Edge\//)) {
2023-10-04 19:39:52,758: DEBUG - document.getElementById('old_browser').style.display = 'block';
2023-10-04 19:39:52,758: DEBUG - }
2023-10-04 19:39:52,758: DEBUG - </script>
2023-10-04 19:39:52,758: DEBUG -
2023-10-04 19:39:52,759: DEBUG -
2023-10-04 19:39:52,759: DEBUG - </main>
2023-10-04 19:39:52,759: DEBUG -
2023-10-04 19:39:52,759: DEBUG -
2023-10-04 19:39:52,760: DEBUG -
2023-10-04 19:39:52,760: DEBUG - </body>
2023-10-04 19:39:52,761: DEBUG - </html>
2023-10-04 19:39:52,761: DEBUG - + [[ yes == \n\o ]]
2023-10-04 19:39:52,762: DEBUG - + sleep 5
2023-10-04 19:39:57,750: DEBUG - + ynh_secure_remove --file=/tmp/tmp.FCinfnfoad
2023-10-04 19:39:57,813: DEBUG - + [[ -d /var/www/paheko/data/data ]]
2023-10-04 19:39:57,814: DEBUG - + [[ -f /var/www/paheko/config.local.user.php ]]
2023-10-04 19:39:57,970: INFO - [####################] > Upgrade of paheko completed
2023-10-04 19:39:57,971: DEBUG - + ynh_exit_properly
2023-10-04 19:39:57,971: DEBUG - + [[ upgrade =~ ^install$|^upgrade$|^restore$ ]]
2023-10-04 19:39:58,985: DEBUG - Checking that required services are up and running...
2023-10-04 19:40:00,451: SUCCESS - paheko mis à jour
we could see on the last upgrade with -F
2023-10-04 19:48:38,906: DEBUG - + curl --silent --show-error --insecure --location --header 'Host: paheko.maindomain.tld' --resolve paheko.maindomain.tld:443:127.0.0.1 https://localhost/index.php --cookie-jar /tmp/ynh-paheko-cookie.txt --cookie /tmp/ynh-paheko-cookie.txt
2023-10-04 19:48:39,024: DEBUG - <!DOCTYPE html>
2023-10-04 19:48:39,025: DEBUG - <html>
2023-10-04 19:48:39,025: DEBUG - <head>
2023-10-04 19:48:39,026: DEBUG - <meta charset="utf-8" />
2023-10-04 19:48:39,026: DEBUG - <style type="text/css">
2023-10-04 19:48:39,026: DEBUG - * { padding: 0; margin: 0; }
2023-10-04 19:48:39,027: DEBUG - html {
2023-10-04 19:48:39,027: DEBUG - height: 100%;
2023-10-04 19:48:39,027: DEBUG - }
2023-10-04 19:48:39,028: DEBUG - body {
2023-10-04 19:48:39,028: DEBUG - font-family: sans-serif;
2023-10-04 19:48:39,028: DEBUG - text-align: center;
2023-10-04 19:48:39,029: DEBUG - display: flex;
2023-10-04 19:48:39,029: DEBUG - align-items: center;
2023-10-04 19:48:39,030: DEBUG - justify-content: center;
2023-10-04 19:48:39,030: DEBUG - height: 100%;
2023-10-04 19:48:39,031: DEBUG - }
2023-10-04 19:48:39,031: DEBUG - h2, p {
2023-10-04 19:48:39,031: DEBUG - margin-bottom: 1rem;
2023-10-04 19:48:39,032: DEBUG - }
2023-10-04 19:48:39,034: DEBUG - div {
2023-10-04 19:48:39,034: DEBUG - position: relative;
2023-10-04 19:48:39,034: DEBUG - max-width: 500px;
2023-10-04 19:48:39,035: DEBUG - padding: 1em;
2023-10-04 19:48:39,035: DEBUG - border-radius: .5em;
2023-10-04 19:48:39,036: DEBUG - background: #ccc;
2023-10-04 19:48:39,036: DEBUG - }
2023-10-04 19:48:39,037: DEBUG - .spinner h2::after {
2023-10-04 19:48:39,037: DEBUG - display: block;
2023-10-04 19:48:39,037: DEBUG - content: " ";
2023-10-04 19:48:39,038: DEBUG - margin: 1rem auto;
2023-10-04 19:48:39,038: DEBUG - width: 50px;
2023-10-04 19:48:39,038: DEBUG - height: 50px;
2023-10-04 19:48:39,038: DEBUG - border: 5px solid #999;
2023-10-04 19:48:39,038: DEBUG - border-radius: 50%;
2023-10-04 19:48:39,039: DEBUG - border-top-color: #000;
2023-10-04 19:48:39,039: DEBUG - animation: spin 1s ease-in-out infinite;
2023-10-04 19:48:39,039: DEBUG - }
2023-10-04 19:48:39,039: DEBUG -
2023-10-04 19:48:39,040: DEBUG - @keyframes spin { to { transform: rotate(360deg); } }
2023-10-04 19:48:39,040: DEBUG - </style>
2023-10-04 19:48:39,040: DEBUG - <meta http-equiv="refresh" content="0;url=https://paheko.maindomain.tld/admin/upgrade.php?next" />
2023-10-04 19:48:39,041: DEBUG - <script type="text/javascript" src="/ynh_portal.js"></script><link type="text/css" rel="stylesheet" href="/ynh_overlay.css"><script type="text/javascript" src="/ynhtheme/custom_portal.js"></script><link type="text/css" rel="stylesheet" href="/ynhtheme/custom_overlay.css"></head>
2023-10-04 19:48:39,041: DEBUG - <body>
2023-10-04 19:48:39,041: DEBUG - <div class="spinner">
2023-10-04 19:48:39,041: DEBUG - <h2>Mise à jour de version :<br />
2023-10-04 19:48:39,042: DEBUG - 1.3.0-rc14 → 1.3.0</h2>
2023-10-04 19:48:39,042: DEBUG - </div>+ [[ yes == \n\o ]]
2023-10-04 19:48:39,042: DEBUG - + sleep 5
2023-10-04 19:48:44,048: DEBUG - + ynh_secure_remove --file=/tmp/tmp.Gl3AFBxEQx
2023-10-04 19:48:44,188: DEBUG - + [[ -d /var/www/paheko/data/data ]]
2023-10-04 19:48:44,189: DEBUG - + [[ -f /var/www/paheko/config.local.user.php ]]
2023-10-04 19:48:44,388: DEBUG - + ynh_exit_properly
2023-10-04 19:48:44,388: DEBUG - + [[ upgrade =~ ^install$|^upgrade$|^restore$ ]]
2023-10-04 19:48:44,389: INFO - [####################] > Upgrade of paheko completed
2023-10-04 19:48:45,399: DEBUG - Checking that required services are up and running...
2023-10-04 19:48:47,336: SUCCESS - paheko mis à jour
!testme
Why do I need
--force
??
Perhaps something wrong with the cookies ?? in the folder tmp
there is a folder ynh-paheko-cookie.txt
cat /tmp/ynh-paheko-cookie.txt
# Netscape HTTP Cookie File
# https://curl.se/docs/http-cookies.html
# This file was generated by libcurl! Edit at your own risk.
#HttpOnly_paheko.yunohost.packaging FALSE / TRUE 0 __c bf2f32dff872378ff2c0
(Ah and of course there are still gazillions of conflicts with master
which should be corrected ...)
!testme
!testme
Why do we need all those config files?
config.local.php
config.local.yunohost.php
config.local.user.php
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)