Some improvements and fix migration

fflorent commented 1 year ago

Problem

migration from Garradin fails
The secret key is not stored accross updates

Solution

some improvements in the script based on:
- This PR: https://github.com/YunoHost-Apps/Experimental_helpers/pull/97
- what also exists for vaultwarden_ynh
In case of failure, restore Garradin
Store secret key on installation

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

fflorent commented 1 year ago

I managed to make the migration work! :)

In order to test that:

yunohost app upgrade garradin -u https://github.com/fflorent/paheko_ynh/tree/migration-fixes

fflorent commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Meow :cat2:

fflorent commented 1 year ago

The error seems related to the CI.

When I run locally my branch:

--- SUCCESS ---

Working time for this test: 2 minutes, 31 seconds (17:46:10)

 ============================================
 Tests summary
 ============================================

-------------  -------------
Package linter:                OK  (2 possible improvements)
Install (root):                OK
Install (subdir):              OK
Install (private):             OK
Install (multi):               OK
Backup/restore:                OK
Upgrade:                       OK
Upgrade (6e100378):            OK
Change url:                    OK

Level results
=============
Level 1 (Installable in at least one scenario)   
Level 2 (Installable in all scenarios)            ok 
Level 3 (Can be upgraded)                         ok 
Level 4 (Can be backup/restored)                  ok 
Level 5 (No linter errors)                        ok 
Level 6 (App is in a community-operated git org)  ok 
Level 7 (Pass all tests + no linter warnings)    
Level 8 (Maintained and long-term good quality)  
Level 9 (Flagged high-quality in app catalog)    

Global level for this application: 0 (Broken)

fflorent commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower:

YunoHost-Apps / paheko_ynh