Fix plugins cannot be installed

yalh76 commented 3 years ago

Problem

@fflorent I want to be able to install plugins like peertube-plugin-creative-commons (using the web interface, going to /admin/plugins/search?pluginType=1 and searching for creative-commons).

But there seems to have conflicts about the nodejs version used by the application and the one used by default by the host (nodejs v8).

Solution

I manage to use __YNH_NODE_LOAD_PATH__ in systemd so the node subprocesses use the same nodejs version as the one used by the peertube process

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

fflorent commented 3 years ago

If I can help by any mean, like helping reproducing the issue I mentioned, don't hesitate :)

yalh76 commented 3 years ago

!testme

yunohost-bot commented 3 years ago

May the CI gods be with you!

yalh76 commented 3 years ago

If I can help by any mean, like helping reproducing the issue I mentioned, don't hesitate :)

I just do a last package_check, then merge and after upgrading, you will be able to test if it's solved :)

YunoHost-Apps / peertube_ynh