YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

Update PeerTube to version 4.0.0 #289

Closed BDouze closed 2 years ago

BDouze commented 2 years ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

tituspijean commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:rocket: Test Badge

fflorent commented 2 years ago

Hi there!

First of all, thanks for your work!

Would you mind also updating nginx accordingly to the latest changes made to the example provided by the project:

Thanks in advance!

BDouze commented 2 years ago

Would you mind also updating nginx accordingly to the latest changes made to the example provided by the project:

done. thanks for noticing I forgot that part

fflorent commented 2 years ago

Hmm, weird errors. I wonder if this relates to the upgrade, I am not sure at all:

 ============================================
  [Test 3/10] Installation in private mode
 ============================================

Error: In use
Running: yunohost app install --force /app_folder -a "domain=sub.domain.tld&email=admin@example.com&is_public=0&port=9000&path=/&admin=package_checker&"
1767 ERROR peertube is already installed
Error: Installation failed.

--- FAIL ---

Working time for this test: 1 minute, 8 seconds (10:05:48)

I am running the package checker locally to see whether it works

fflorent commented 2 years ago

Run locally, no issue:

 ============================================
 Tests summary
 ============================================

Package linter:                OK  (1 warnings, 3 possible improvements)
Install (root):                OK
Install (private):             OK
Backup/restore:                OK
Upgrade:                       OK
Upgrade (f4b43fd8):            OK
Upgrade (08bf3fce):            OK
Upgrade (f3bb0200):            OK
Upgrade (ed59a268):            OK
Upgrade (83a06ca4):            OK

Level results
=============
Level 1 (Installable in at least one scenario)    OK
Level 2 (Installable in all scenarios)            OK
Level 3 (Can be upgraded)                         OK
Level 4 (Can be backup/restored)                  OK
Level 5 (No linter errors)                        OK
Level 6 (App is in a community-operated git org)  OK
Level 7 (Pass all tests + no linter warnings)
Level 8 (Maintained and long-term good quality)
Level 9 (Flagged high-quality in app catalog)

Global level for this application: 6 (App is in a community-operated git org)
fflorent commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

fflorent commented 2 years ago

LGTM ! :slightly_smiling_face:

ericgaspar commented 2 years ago

Do you have poor fonts rendering in Peertube?

Capture d’écran 2

BDouze commented 2 years ago

nope

Screenshot 2021-12-23 at 23 42 41
fflorent commented 2 years ago

No problem for me either :)

Maybe purge the webbrowser cache?