search

YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

Few improvements #301

Closed yalh76 closed 2 years ago

yalh76 commented 2 years ago

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed! Test Badge

fflorent commented 2 years ago

One question: if I attempt to install on a new container, I get this error:

Info: DEBUG - [peertube.ynh-dev.local:443] 2022-01-11 19:48:39.994 error: Error in Redis client. {
Info: DEBUG -   "err": {
Info: DEBUG -     "stack": "Error: connect ECONNREFUSED 127.0.0.1:6379\n    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1161:16)",
Info: DEBUG -     "message": "Redis connection to localhost:6379 failed - connect ECONNREFUSED 127.0.0.1:6379",
Info: DEBUG -     "errno": -111,
Info: DEBUG -     "code": "ECONNREFUSED",
Info: DEBUG -     "syscall": "connect",
Info: DEBUG -     "address": "127.0.0.1",
Info: DEBUG -     "port": 6379
Info: DEBUG -   }
Info: DEBUG - }

I see that redis is not in the dependencies of the package.

Could it be missing in _common.sh?

fflorent commented 2 years ago

Sounds like an issue with my ynh-dev container. Nevermind, I'll fix that and try to do some tests.