YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

When Upgrade to 4.1 - Prosody install breaks metronome XMPP service #311

Closed madmaxlamenace closed 12 months ago

madmaxlamenace commented 2 years ago

Describe the bug

After an update of Peertube to 4.1 It seems the service XMPP metronome was crashed and it doesn't work anymore

Context

Steps to reproduce

Try to use your xmpp yunohost account on your default domain.tld The client says : le serveur n'est pas responsable pour ce domaine yunohost

Expected behavior

The client must say : Connected

Corrective action resolved the incident on metronome and XMPP yunohost service but not resolved the problem on prosody peertube

Logs

nothing

BDouze commented 2 years ago

Prosody has been added for the live chat peertube plugin. And it does not need the prosody service to be running. the plugin is spawning its own prosody process. Prosody should be installed with its service disabled

madmaxlamenace commented 2 years ago

After Peertube 4.1 upgrade the XMPP service doesn't work anymore. For me it's an issue. A program breaking another program when installed is a bug issue.

BDouze commented 2 years ago

I agree. I was only stating that peertube does not need the prosody service to be started. When the live chat plugin is spawning its own prosody process it does so using a different port than the one used by the service which does not conflict with metronome. More details in #278

yalh76 commented 2 years ago

I agree. I was only stating that peertube does not need the prosody service to be started. When the live chat plugin is spawning its own prosody process it does so using a different port than the one used by the service which does not conflict with metronome. More details in #278

Yes, but other package like jitsi need the prosody service started, so it was much easier to do it that way

chbmeyer commented 2 years ago

This is annoying. I'm relying on XMPP for Yunohost and don't care whether it's metronome or prosody.

Since Peertube doesn't need the prosody service there is no reason to start it (and break metronome). I don't care about Jitsie, too, but I need a working XMPP.

So I think a) YNH should move completely to prosody (with disabled prosody till it works as default and metronome is dropped) or b) Jitsi should work with metronome (or metronome with Jitsi) without the need for prosody

But enabling prosody from Peertube (without the need to do so) because of Jitsi needing it is not right since it breaks Yunohost default config.

Of course I can disable prosody (as mentioned above), but then it re-enables itself after a while and my XMPP fails silently (or I get automatic diagnosis mails: "[ERROR] Service prosody is dead :("

So I agree: it "is a bug issue". Please fix it.

yalh76 commented 2 years ago

So I think a) YNH should move completely to prosody (with disabled prosody till it works as default and metronome is dropped)

There is no plan to move yunohost from metronome to prosody

or b) Jitsi should work with metronome (or metronome with Jitsi) without the need for prosody

I've tryed during hours to make jitsi works with metronome. If you can do it, feels free to do a PR

But enabling prosody from Peertube (without the need to do so) because of Jitsi needing it is not right since it breaks Yunohost default config.

If you think there is a better way to do it, feel free to do the required PRs for that. For example, installing the pluging live chat and prosody could be optional, etc ...

eauchat commented 2 years ago

Hello thank you all for this thread's requests and also answers of why the situation is as it is. It's nice to understand why suddenly prosody was appearing in the list of installed apps.
From this I understand that if I'm not needing metronome, I can safely ignore the warning of the diagnosis that says that metronome has crashed.
I have one question though, since peertube upgrade, the diagnosis tells me that /etc/nsswitch.conf has been manually modified. I was doing other upgrades at the same time, so I'm wondering if this happens because of the peertube update, and if I should ignore that warning. This is the modification reported:

-hosts:          files myhostname dns
+hosts:          files myhostname mdns4_minimal [NOTFOUND=return] dns
yalh76 commented 2 years ago

Hello thank you all for this thread's requests and also answers of why the situation is as it is. It's nice to understand why suddenly prosody was appearing in the list of installed apps. From this I understand that if I'm not needing metronome, I can safely ignore the warning of the diagnosis that says that metronome has crashed. I have one question though, since peertube upgrade, the diagnosis tells me that /etc/nsswitch.conf has been manually modified. I was doing other upgrades at the same time, so I'm wondering if this happens because of the peertube update, and if I should ignore that warning. This is the modification reported:

-hosts:          files myhostname dns
+hosts:          files myhostname mdns4_minimal [NOTFOUND=return] dns

as far as I know peertube_ynh upgrade doesn't modify /etc/nsswitch.conf

tomdereub commented 1 year ago

I'm still having this issue at each peertube upgrade. I don't need prosody, so each time I have to manually uninstall prosody. If I just stop prosody service and restart metronome, I get the issue again if the server reboots. As proposed by @yalh76 , I think the better solution would be that installing the pluging live chat and prosody be optional. That said, I know it depends on volunteer's energy and time... But I think it's worth re-opening this issue.

madmaxlamenace commented 1 year ago

you could try to disable the service using systemctl systemctl disable prosody I think this can solved the issue for the next upgrade.