YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

Adapt the package to work with the runners #382

Closed tio-trom closed 11 months ago

tio-trom commented 1 year ago

Please follow our discussion here https://github.com/Chocobozzz/PeerTube/issues/5849 - it seems that with the new "runners" feature the nginx file must be adapted.

lapineige commented 1 year ago

I will also link this : #381

lapineige commented 1 year ago

Also the upstream issue was closed https://github.com/Chocobozzz/PeerTube/issues/5849#issuecomment-1607300859 because it should be fixed on Peertube side in a future version.

tio-trom commented 1 year ago

Also the upstream issue was closed Chocobozzz/PeerTube#5849 (comment) because it should be fixed on Peertube side in a future version.

Yes some things, but we need to add the runner to the production file https://github.com/Chocobozzz/PeerTube/issues/5849#issuecomment-1605915295 and add them to nginx too https://github.com/Chocobozzz/PeerTube/issues/5849#issuecomment-1605773113

lapineige commented 1 year ago

For your information using #381 I successfully tried it and runners work out of the box :D

tio-trom commented 1 year ago

For your information using #381 I successfully tried it and runners work out of the box :D

Yes but did you try with big files? Because that was the issue really.

lapineige commented 1 year ago

:bulb: Thanks, I didn't understand this before !

So yes, this is an issue with the Peertube app.