YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

Raise timeout duration for Yarn (helps with slow hardware) #397

Closed lapineige closed 6 months ago

lapineige commented 6 months ago

https://forum.yunohost.org/t/can-not-install-peertube/27740/7

A 30s timeout is too low on many HDD or other slow hardware.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige commented 6 months ago

!testme

yunohost-bot commented 6 months ago

Meow :cat2: Test Badge

lapineige commented 6 months ago

I can confirm that the issue is fixed with this commit.

lapineige commented 6 months ago

!testme

yunohost-bot commented 6 months ago

:carousel_horse: Test Badge

lapineige commented 6 months ago

But there are other issues : https://paste.yunohost.org/raw/ufasuropar

[domain2.tld:443] 2023-12-26 12:06:34.027 error: Cannot install plugin peertube-plugin-auth-ldap, removing it... There is no plugin table ? 🤔

lapineige commented 6 months ago

So the other issue seems to be related to the LDAP plugin, and not specific to this PR.

As it fixes install issues, according to my testing (CI is failing because of the plugin), I suggest to merge it :slightly_smiling_face:

lapineige commented 6 months ago

https://github.com/Chocobozzz/PeerTube/issues/6139#issuecomment-1870030515

lapineige commented 6 months ago

400 should also improve installation on slow hardware.

lapineige commented 6 months ago

I didn't merge it… somehow merging #401 merged this too ??

Well I think this should have been reviewed for approval, as the timing is arbitrary and quite long (5min instead of 30s). ping @YunoHost-Apps, any opinion ?