Reapply "Merge pull request #390 from YunoHost-Apps/testing" : 6.0.2 + packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init

[Tagadda]

This reverts commit d5d2f8bd3b39db5853f091bba4a772d5641aeeed. Equals to this https://github.com/YunoHost-Apps/peertube_ynh/pull/391

6.0.2 + packaging v2 + fix install 502 error + timeout on slow hardware + wait for DB full init

• Update to package version 2
• Update the app to 6.0.2

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[yunohost-bot]

:rocket:

[lapineige]

So this commit brings (back) Peertube v6.

It requires to generate "storyboard" (the preview in the timeline) for each old videos. https://docs.joinpeertube.org/maintain/tools#generate-storyboard

Admins can do it manually like that :

cd /var/www/peertube/
yunohost app shell peertube
NODE_CONFIG_DIR=/var/www/peertube/config NODE_ENV=production npm run create-generate-storyboard-job -- --all-videos

It consumes a bit of CPU time, but I believe it's necessary to do it after the upgrade, in the upgrade script. Let's implement it ?

[lapineige]

@ericgaspar (and others) do you get what's the big deal with the (web)-videos thing ? What option should it be ? What's the effect ?

[lapineige]

The LDAP issue is back… but it should have waited for the service to start before installing it (as in #400), so what's the matter ? 🤔

[lapineige]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[lapineige]

May I try it ? Is that useful for you ? :)

[ericgaspar]

We do not need to bump the version

[lapineige]

405 Issue solved !

[lapineige]

We do not need to bump the version

If people did upgrade to the previous faulty v0.6.2~ynh1, the new upgrade won't be available. Hence the bump.

[lapineige]

Do we know if we actually followed all important notes from here ? 🤔 https://docs.joinpeertube.org/CHANGELOG

• [x] Ensure location = /api/v1/videos/upload-resumable { has been replaced by location ~ ^/api/v1/videos/(upload-resumable|([^/]+/source/replace-resumable))$ { in your nginx configuration

• [x] Ensure you updated storage.web_videos configuration value to use web-videos/ directory name #412

• [x] Ensure your directory name on filesystem is the same as storage.web_videos configuration value: directory on filesystem must be renamed from videos/ to web-videos/ to represent the value of storage.web_videos

• [x] Remove NodeJS 16 support

• [x] Check in production.yaml that you use 127.0.0.1 instead of localhost for listen.hostname, database.hostname and redis.hostname as Node 18 favours IPv6 for localhost resolution (ping @alexAubin, good catch :)

• [ ] Advice about the WebTorrent change maybe ?

  Remove WebTorrent support in player: "WebTorrent videos" are renamed to "Web Video". The video format is the same, we just stop to use P2P for these videos There is no "Auto" quality anymore for Web Videos. The viewer has to explicitly choose the video resolution We still use P2P with the HLS player, which is the recommended transcoding format since several versions

• [ ] Configuration key that you must update in your production.yaml if not automatically done by your upgrade script:

  storage.videos must be renamed to storage.web_videos: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L151 Configuration value of storage.web_videos must have the directory name to be changed from videos/ to web-videos/: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L151 Directory on filesystem must be renamed from videos/ to web-videos/ to represent the value of storage.web_videos Classic installation: sudo -u peertube mv '/var/www/peertube/storage/videos/' '/var/www/peertube/storage/web-videos/' Docker installation: mv '/path-to-docker-installation/docker-volume/data/videos/' '/path-to-docker-installation/docker-volume/data/web-videos/' transcoding.webtorrent must be renamed to transcoding.web_videos: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L532 object_storage.videos must be renamed to object_storage.web_videos. The value of object_storage.web_videos.bucket_name doesn't need to be changed: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L223 storage.storyboards must be added: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L157

• [x] You must update nginx configuration: https://github.com/Chocobozzz/PeerTube/blob/develop/support/nginx/peertube

  location ~ ^/static/(thumbnails|avatars)/ { block must be removed location = /api/v1/videos/upload-resumable { must be updated to location ~ ^/api/v1/videos/(upload-resumable|([^/]+/source/replace-resumable))$ { location ~ ^(/static/(webseed|streaming-playlists)/private/)|^/download { must be updated to location ~ ^(/static/(webseed|web-videos|streaming-playlists)/private/)|^/download { location ~ ^/static/(webseed|redundancy|streaming-playlists)/ { must be updated to location ~ ^/static/(webseed|web-videos|redundancy|streaming-playlists)/ {

[ericgaspar]

!testme

[yunohost-bot]

:rocket:

[ericgaspar]

I still have an issue with plugins not loading... domain.tld/admin/plugins/show/peertube-plugin-auth-ldap with message Ce plugin ne dispose pas de paramétrage.

[lapineige]

Update went fine on 2 servers.

[lapineige]

I still have an issue with plugins not loading... domain.tld/admin/plugins/show/peertube-plugin-auth-ldap with message Ce plugin ne dispose pas de paramétrage.

I can see this admin page… strange :thinking:

[lapineige]

@ericgaspar regarding the "todo-list" I made above, could you update it if you handle some of the tasks ? I'm having an hard time checking what was done with all those commits :sweat_smile:

[ericgaspar]

list of issues so far:

• [ ] Plugins setting are not showing
• [ ] The $admin_pass variable get deleted at upgrade (POST_INSTALL don't get the root user password but ADMIN_PASS displayed). I don't know if we should let user choose the password at install for the user root

[lapineige]

• I don't know if we should let user shoose the password at install for the user root

It would be better in theory, but as we send it by mail, it's already a security issue and they should change it... So I would rather advice for a quick change.

[ericgaspar]

• I don't know if we should let user shoose the password at install for the user root

It would be better in theory, but as we send it by mail, it's already a security issue and they should change it... So I would rather advice for a quick change.

The password is send with POST_INSTALL.md not mail. It is displayed in the app admin as a popup window, who will disappear once you click the green button.

[lapineige]

It was sent by email too the last time I installed it 🤔

[lapineige]

I still have an issue with plugins not loading... domain.tld/admin/plugins/show/peertube-plugin-auth-ldap with message Ce plugin ne dispose pas de paramétrage.

I can see this admin page… strange 🤔

Do you have any log ? For instance in Peertube webadmin logs ?

[ericgaspar]

!testme

[yunohost-bot]

:sunflower:

[lapineige]

Ready for manual testing ?