YunoHost-Apps / peertube_ynh

Federated (ActivityPub) video streaming platform using P2P for YunoHost
https://joinpeertube.org/fr/
GNU Affero General Public License v3.0
87 stars 27 forks source link

Upgrade from 5.2.1 to 6.0.2 fails #416

Closed TILvids closed 5 months ago

TILvids commented 6 months ago

Here's the yunopaste. Any ideas?

https://paste.yunohost.org/raw/agabodumig

isAAAc commented 6 months ago

EDIT: oh i tried yesterday night, so, before the merge, i'll try again in a few (i'm watching a video on peertube at this moment ^^)

root@krashboyz:~# yunohost --version
yunohost: 
  repo: stable
  version: 11.2.9.1
yunohost-admin: 
  repo: stable
  version: 11.2.4
moulinette: 
  repo: stable
  version: 11.2
ssowat: 
  repo: stable
  version: 11.2

Same here https://paste.yunohost.org/raw/anovapozim

EDIT 2: i tried with the testing branch, but i think it's the same trouble: root@krashboyz:~# yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh/tree/testing --debug

https://paste.yunohost.org/raw/iqacamevuv

isAAAc commented 5 months ago

logs for 5.2.1~ynh1 to 6.0.2~ynh3 (KO too) https://paste.yunohost.org/raw/imejetaxij

alexAubin commented 5 months ago

WARNING - ./upgrade: line 16: admin: unbound variable

apparently it's an old install which didnt have the admin defined ...

you can define the admin with yunohost app setting peertube admin -v some_admin_user with some_admin_user being an existing yunohost user

maybe we should add PRE_UPGRADE warning for this specific version to explain this

isAAAc commented 5 months ago

looks much better after this command yes :)

yunohost app setting peertube admin -v isaaac

i have this message during the upgrade, :

Success! peertube upgraded
==========
- peertube can now be accessed at [https://media.krashboyz.org/](https://media.krashboyz.org/)
- The admin username is: root
- The admin password is: __ADMIN_PASS__
==========

so is it isaaac or root the admin user ? :thinking:

alexAubin commented 5 months ago

Well uh yes that's curious .. root is hardcoded here : https://github.com/YunoHost-Apps/peertube_ynh/blob/master/doc/POST_UPGRADE.md?plain=1#L2

dunno if that's intentional or ...

isAAAc commented 5 months ago

@TILvids : does this command fix your issue too ?

ashledombos commented 5 months ago

I did not see this issue until now, I found a workaround it by adding admin: someuser in /etc/yunohost/apps/peertube/settings.yml It’s less elegant, but installation worked.

However, logins don’t work anymore (either an account, nor the original root account), but that’s another issue.

Note: from memory I had the same outpout as https://github.com/YunoHost-Apps/peertube_ynh/issues/416#issuecomment-1892148444, and also lost All Users access to Peertube, so had to add this access back by hand.

isAAAc commented 5 months ago

upgrade to 6.0.3~ynh1 done for me without any trouble, case closed on my side ;)

alexAubin commented 5 months ago

Closing, copypasta of the discussed fix:

you can define the admin with yunohost app setting peertube admin -v some_admin_user with some_admin_user being an existing yunohost user