Make installation compatible with arm64 and armhf architectures

[tituspijean]

Closes #18

PR Status

• [x] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Thovi98]

Could you please tell me where you found the armhf sha256? I see only the ones for amd64 and arm64 in the Docker Hub

And I don’t understand how the script will find Photoprism (and the right version) with only the sha256, but that’s maybe my lack of knowledge 😁

[tituspijean]

It's in another tag: https://hub.docker.com/layers/photoprism/photoprism/photoprism/220730-armv7/images/sha256-4e0b39a06e0f7ecd11aa8cbd84c739cba3417c99348f52e3433cdeaeeb5474cb?context=explore

However, I realize now that armhf != armv7 :(

[Limezy]

Hi @tituspijean, do we have an arm64 CI ? I don't have any arm64 architecture to test your PR on right now...

[tituspijean]

Right now, no. I had tried to make one on my RPi4. I'll try to spin it up again during today's YunoCamp session.

[Limezy]

Ok ! Hard for me to make a review of your PR, but I let you merge whenever you feel it's OK @Thovi98 do you have a Pi or something to test on your side ?

[Thovi98]

@Thovi98 do you have a Pi or something to test on your side ?

I’ve not, sorry :(

[centralscrutinizer21]

I gave this branch a try without success https://paste.yunohost.org/raw/orenohogix

[Limezy]

@centralscrutinizer21 : Many thanks for testing, that will be very useful. It looks like there is still a few things to improve, I'll try to have a look.

[tituspijean]

I think I wrote a bad case block in _common.sh.

[tituspijean]

@centralscrutinizer21 you may try again. :)

[centralscrutinizer21]

@tituspijean worked like a charm!

[navanchauhan]

Why don't we simply compile the program from scratch rather than using the docker-extractor? PhotoPrism looks like a simple program written in Go https://github.com/photoprism/photoprism/blob/develop/scripts/build.sh

I am happy to contribute the relevant PR that builds on the device itself if the package maintainer wants to go in that direction. All we would need to do is include a custom helper that installs Go -> Builds a static binary -> Uninstalls Go

I did that for ListMonk a few days back (ListMonk Repo)

[tituspijean]

As far as I know we moved to Docker image extraction because the compilation was taking A LOT of resources.

[Limezy]

Why don't we simply compile the program from scratch rather than using the docker-extractor? PhotoPrism looks like a simple program written in Go https://github.com/photoprism/photoprism/blob/develop/scripts/build.sh

I am happy to contribute the relevant PR that builds on the device itself if the package maintainer wants to go in that direction. All we would need to do is include a custom helper that installs Go -> Builds a static binary -> Uninstalls Go

I did that for ListMonk a few days back (ListMonk Repo)

Thanks for your proposal ! This is actually how I did package Photoprism before. It's way harder than that in fact, because of the dozens and dozens of required dependancies, not all using the Go system. You may have a look at past versions of the master branch if you want.

As far as I know we moved to Docker image extraction because the compilation was taking A LOT of resources.

Yep exactly ! The CI was crashing every time. Feel free anyway to contribute to this package, every help is warmly welcomed. We are currently changing to have @Thovi98 as the official maintainer of the app

[Limezy]

!testme !bullseyetestme

[yunohost-bot]

:carousel_horse:

[yunohost-bot]

[Bullseye :horse:] May the CI gods be with you!

[Limezy]

These tests will not secure the fact that the package will work on arm64 or other architectures. However, if the tests are running on the amd64 CI, I'll consider this PR as non regressing, hence mergeable.