proxy pass final slash forgotten

YunoHost-Apps / piped_ynh

piped package for YunoHost

https://piped.video/trending

GNU Affero General Public License v3.0

2 stars 1 forks source link

proxy pass final slash forgotten #30

Closed OniriCorpe closed 4 months ago

OniriCorpe commented 4 months ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yunohost-bot commented 4 months ago

:carousel_horse:

orhtej2 commented 4 months ago

Does it cause any problem? There's a significant semantics difference and in my testing it works as its but reference conf passes to socket so I'm not sure

OniriCorpe commented 4 months ago

after testing it, this crashes nginx: nginx: [emerg] "proxy_pass" cannot have URI part in location given by regular expression, or inside named location, or inside "if" statement, or inside "limit_except" block in /etc/nginx/conf.d/piped.oniricorpe.eu.d/piped.conf:31

orhtej2 commented 4 months ago

That can be circumvented as long as proxy is not suppressed to know the path but I feel it should not pass to root