Testing - Githubissues

ericgaspar commented 3 months ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 3 months ago

!testme

yunohost-bot commented 3 months ago

:books: :bug:

yunohost-bot commented 3 months ago

Alrighty!

ericgaspar commented 3 months ago

!testme

yunohost-bot commented 3 months ago

Fingers crossed!

yunohost-bot commented 3 months ago

:books: :worm:

ericgaspar commented 3 months ago

!testme

yunohost-bot commented 3 months ago

Alrighty!

ericgaspar commented 3 weeks ago

!testme

yunohost-bot commented 3 weeks ago

Alrighty!

yunohost-bot commented 3 weeks ago

Living in the future, are we?

JimboJoe commented 3 weeks ago

!testme

yunohost-bot commented 3 weeks ago

:books:

yunohost-bot commented 3 weeks ago

Fingers crossed!

JimboJoe commented 3 weeks ago

We're getting there: the LDAP plugin configuration is fixed, and there's a last remaining problem in the upgrade with the files-keeping mechanism...

JimboJoe commented 3 weeks ago

!testme

yunohost-bot commented 3 weeks ago

:bug:

yunohost-bot commented 3 weeks ago

:carousel_horse:

JimboJoe commented 3 weeks ago

@ericgaspar I don't understand why the saved _data is not a directory in the CI. Installing manually creates a populated _data directory, and force-upgrading does work... EDIT: OK, I missed that the upgrade works, and only upgrade from older versions fails (hence my irrelevant tests). Just tried installing the 13.1.0 commit, and the _data directory is a symbolic link to /home/yunohost.app/piwigo/_data, hence the error...

JimboJoe commented 3 weeks ago

In my understanding:

in the old days, the data directories (_data, galleries, uploads) were store in /home/yunohost.app/piwigo and a symbolic link was created in the install dir (/var/www/piwigo)
Then the upstream app started managing a "data dir" config, and we set it up, not needing the symbolic links any more; the data dirs were still stored in /home/yunohost.app/piwigo

So... in any way, the data directories are kept during the upgrade, so we shouldn't need to preserve the corresponding ones in the install dir (not used) during the upstream source uncompressing (revert from that change). And it should also fix the remaining "upgrade from older version" tests

@ericgaspar Does that sound legit...?

ericgaspar commented 3 weeks ago

To be honest, I don't remember exactly what the issue was on the Master branch... something to do with images not showing up due to symlinks not working. This PR removes the use of data_dir in favor of the install_dir/(_data, galleries, uploads) location. That being said, I'm not sure if this is the right strategy and if upgrading won't wipe out existing data...

JimboJoe commented 3 weeks ago

Ah I see the analysis in https://github.com/YunoHost-Apps/piwigo_ynh/issues/128#issuecomment-2156085035 Then, a potentially simpler/less risky solution couldn't be to configure the data_location and upload_dir settings in the app with a relative path (i.e. ../../..__DATA_DIR__)...?

ericgaspar commented 3 weeks ago

EDIT: ah ok. I understand. I commited #142. the _data, galleries, uploads files were created in the data_dir location and $conf['data_location'] = '../../..__DATA_DIR__/_data/'; is added to the config file. Let's see if that does the trick

ericgaspar commented 3 weeks ago

!testme

yunohost-bot commented 3 weeks ago

Living in the future, are we?