YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost
http://piwigo.org/
GNU General Public License v2.0
6 stars 4 forks source link

Don't backup _data temporary folder (closes #17) #18

Closed JimboJoe closed 6 years ago

JimboJoe commented 6 years ago

Problem

_data folder is backed-up, whereas it's a temporary folder, duplicating the upload folder which contains every needed data (see #17).

Solution

Don't backup the _data folder. The only drawback is that Piwigo will need to regenerate temporary data (thumbnails, different photos sizes) on the fly (as it already does when the photo is viewed/browsed for the first time).

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

maniackcrudelis commented 6 years ago

LGTM and code review OK.

JimboJoe commented 6 years ago

maybe @LeOSW42 could try the upgrade...?

LeOSW42 commented 6 years ago

Upgrade an backup worked fine. Restore not tested, but seems ok.

JimboJoe commented 6 years ago

Thanks! So, let's merge in 3 days 👍