Closed JimboJoe closed 6 years ago
Upgrade OK, Code review OK.
This PR is in "Need attention" since 32 days. We lack only a LGTM.
Let's merge anyway !
Well, our rules state that anyone can check the LGTM check-box here so... @alexAubin ... ? :wink:
Will be merged in 2 days. (31 days is already too much.)
Finally, can we merge it tomorrow ? (already more than one month... I think : if the ppl haven't said anything since 31. Jan, nobody will say something in 3 days...) @JimboJoe @maniackcrudelis ?
To me that sounds legit, it only affects backup/restore scripts so naively it's not like it's gonna break the upgrade or antyhing...
Problem
_data
folder is backed-up, whereas it's a temporary folder, duplicating theupload
folder which contains every needed data (see #17).Solution
_data
folder. The only drawback is that Piwigo will need to regenerate temporary data (thumbnails, different photos sizes) on the fly (as it already does when the photo is viewed/browsed for the first time).PR Status
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
Minor decision
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.