Testing - Githubissues

YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost

http://piwigo.org/

GNU General Public License v2.0

6 stars 4 forks source link

Testing #27

Closed JimboJoe closed 6 years ago

JimboJoe commented 6 years ago

Problem

Application is not up-to-date
Galleries directory is used when using the synchronization feature: it can be huge and must be kept during upgrade

Solution

Upgrade to upstream version 2.9.4
Move galleries directory to /home/yunohost.app and don't delete it during upgrade

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Maniack C
[x] Approval (LGTM) : Maniack C
[x] Approval (LGTM) : Josué
CI succeeded : When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe commented 6 years ago

Now ready to be reviewed.

maniackcrudelis commented 6 years ago

Code review OK

Josue-T commented 6 years ago

Let's merge in 3 days

JimboJoe commented 6 years ago

Looks like we got a little bit late :innocent: