Update LDAP plugin and use WS API for activation - Githubissues

YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost

http://piwigo.org/

GNU General Public License v2.0

6 stars 4 forks source link

Update LDAP plugin and use WS API for activation #45

Closed JimboJoe closed 4 years ago

JimboJoe commented 4 years ago

Problem

The LDAP plugin installed with this package is obsolete. If upgraded via Piwigo, it leads to a broken authentication as the newer version uses MySQL for configuration instead of a plain file.

Solution

Use latest plugin version
Implement Piwigo Web Services API calls to activate it, in particular to have the internal configuration MySQL table created

(PR #884 on ynh_local_curl opened on core)

PR Status

[x] Code finished.
[x] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Kay0u
[x] Approval (LGTM) : Kay0u
[x] Approval (LGTM) : Maniack C
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis commented 4 years ago

Can be merged in 3 days