Validate quality level 5 conformance

YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost

http://piwigo.org/

GNU General Public License v2.0

6 stars 4 forks source link

Validate quality level 5 conformance #5

Closed JimboJoe closed 7 years ago

JimboJoe commented 7 years ago

This levels needs to be formally assessed as there are residual warnings stated by package_linter :

>>>> _COMMON.SH SCRIPT <<<<
✘ Line  21 you should add "sudo" before this command line: 
    chmod 755 $TMPDIR
✘ Line  27 you should add "sudo" before this command line: 
    rm "$archive"

These commands manipulates temporary files and folders, for which no administrator privilege is need.

maniackcrudelis commented 7 years ago

Ok for me ;)