fix upgrade - Githubissues

YunoHost-Apps / piwigo_ynh

Piwigo package for YunoHost

http://piwigo.org/

GNU General Public License v2.0

6 stars 4 forks source link

fix upgrade #50

Closed kay0u closed 4 years ago

kay0u commented 4 years ago

Problem

#49

Solution

Fix #49
Backward compatibility only when changing the version of the application

PR Status

[ ] Code finished.
[ ] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[ ] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[x] Code review : Maniack C
[x] Approval (LGTM) : Maniack C
[ ] Approval (LGTM) :
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe commented 4 years ago

Upgrade from fresh ~ynh1 fails on my side (log here). Did you test it on your side?

JimboJoe commented 4 years ago

:up:

vrubiolo commented 4 years ago

Hi guys, any news on the matter here? Note that the update fails for me too and for others as well, cf https://forum.yunohost.org/t/official-app-piwigo/3999/22. Thanks much for your answer!

JimboJoe commented 4 years ago

Hello, I'm sorry, but bumping everywhere and everyday unfortunately won't make things happen... I personally don't have time at the moment, please step in to help fixing or wait for other contributors to do so...

vrubiolo commented 4 years ago

Hi @JimboJoe

Thanks for replying and sorry for appearing to be pushy. That was not my intent.

There seemed to be no activity on any of the threads so I was wondering what was going on after you asked for testing feedback on https://forum.yunohost.org/t/official-app-piwigo/3999/23?u=vinz and that me and mr_smithers had replied with our results.

I perfectly understand you might not have time for now. Thanks for saying so. That allows others to try and work on it. The Yuno team appears to be made entirely of volunteers who work on their free time so this is perfectly normal.

JimboJoe commented 4 years ago

:up: Several reports on the forum that that fix eventually works... :sweat_smile:

kay0u commented 4 years ago

I can't approve my own PR :-)

JimboJoe commented 4 years ago

At least you can verbally approve my latest changes :wink:

JimboJoe commented 4 years ago

Let's say we can merge in 3 days.